[alsa-devel] [PATCH 13/15] sound/soc: davinci: check kzalloc() result (typo)
The code checks 'davinci_vc' after kzalloc() and do not checks 'davinci_vcif_dev' that kzalloc() result is assigned to. It seems that it is a typo (autocompletion?).
Signed-off-by: Kulikov Vasiliy segooon@gmail.com --- sound/soc/davinci/davinci-vcif.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/davinci/davinci-vcif.c b/sound/soc/davinci/davinci-vcif.c index 9aa980d..4867853 100644 --- a/sound/soc/davinci/davinci-vcif.c +++ b/sound/soc/davinci/davinci-vcif.c @@ -203,7 +203,7 @@ static int davinci_vcif_probe(struct platform_device *pdev) int ret;
davinci_vcif_dev = kzalloc(sizeof(struct davinci_vcif_dev), GFP_KERNEL); - if (!davinci_vc) { + if (!davinci_vcif_dev) { dev_dbg(&pdev->dev, "could not allocate memory for private data\n"); return -ENOMEM;
On Fri, 2010-07-16 at 20:16 +0400, Kulikov Vasiliy wrote:
The code checks 'davinci_vc' after kzalloc() and do not checks 'davinci_vcif_dev' that kzalloc() result is assigned to. It seems that it is a typo (autocompletion?).
Signed-off-by: Kulikov Vasiliy segooon@gmail.com
sound/soc/davinci/davinci-vcif.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/davinci/davinci-vcif.c b/sound/soc/davinci/davinci-vcif.c index 9aa980d..4867853 100644 --- a/sound/soc/davinci/davinci-vcif.c +++ b/sound/soc/davinci/davinci-vcif.c @@ -203,7 +203,7 @@ static int davinci_vcif_probe(struct platform_device *pdev) int ret;
davinci_vcif_dev = kzalloc(sizeof(struct davinci_vcif_dev), GFP_KERNEL);
- if (!davinci_vc) {
- if (!davinci_vcif_dev) { dev_dbg(&pdev->dev, "could not allocate memory for private data\n"); return -ENOMEM;
13,14 & 15
Acked-by: Liam Girdwood lrg@slimlogic.co.uk
On Sat, Jul 17, 2010 at 06:45:33PM +0100, Liam Girdwood wrote:
On Fri, 2010-07-16 at 20:16 +0400, Kulikov Vasiliy wrote:
The code checks 'davinci_vc' after kzalloc() and do not checks 'davinci_vcif_dev' that kzalloc() result is assigned to. It seems that it is a typo (autocompletion?).
Signed-off-by: Kulikov Vasiliy segooon@gmail.com
Acked-by: Liam Girdwood lrg@slimlogic.co.uk
Applied, thanks. Kulikov could you please check the subject lines you're using for your patches - try to be consistent with the rest of the patches for the same code area.
participants (3)
-
Kulikov Vasiliy
-
Liam Girdwood
-
Mark Brown