[alsa-devel] [PATCH 1/2] ASoC: simple-card-utils: add __printf attribute
asoc_simple_card_set_dailink_name() uses devm_kvasprintf() to format some of its arguments. Adding a __printf attribute to this function makes it possible to detect at compile-time errors related to format strings.
Signed-off-by: Nicolas Iooss nicolas.iooss_linux@m4x.org --- include/sound/simple_card_utils.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/include/sound/simple_card_utils.h b/include/sound/simple_card_utils.h index 86088aed9002..3207b1a70d38 100644 --- a/include/sound/simple_card_utils.h +++ b/include/sound/simple_card_utils.h @@ -27,6 +27,7 @@ int asoc_simple_card_parse_daifmt(struct device *dev, struct device_node *codec, char *prefix, unsigned int *retfmt); +__printf(3, 4) int asoc_simple_card_set_dailink_name(struct device *dev, struct snd_soc_dai_link *dai_link, const char *fmt, ...);
include/sound/simple_card_utils.h is handled by ASoC maintainers, as stated in https://lkml.org/lkml/2016/8/22/307, and include/sound/simple_card.h seems to be an ASoC file too.
Signed-off-by: Nicolas Iooss nicolas.iooss_linux@m4x.org --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS index 0bbe4b105c34..c840582d1439 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11012,6 +11012,8 @@ S: Supported F: Documentation/devicetree/bindings/sound/ F: Documentation/sound/alsa/soc/ F: sound/soc/ +F: include/sound/simple_card.h +F: include/sound/simple_card_utils.h F: include/sound/soc*
SOUND - DMAENGINE HELPERS
Hi Nicolas
include/sound/simple_card_utils.h is handled by ASoC maintainers, as stated in https://lkml.org/lkml/2016/8/22/307, and include/sound/simple_card.h seems to be an ASoC file too.
Signed-off-by: Nicolas Iooss nicolas.iooss_linux@m4x.org
MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS index 0bbe4b105c34..c840582d1439 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11012,6 +11012,8 @@ S: Supported F: Documentation/devicetree/bindings/sound/ F: Documentation/sound/alsa/soc/ F: sound/soc/ +F: include/sound/simple_card.h +F: include/sound/simple_card_utils.h F: include/sound/soc*
We will have more simple_xxx_card in the future I think. (I posted simple_scu_card, for example) So, how about this or similar ? It can be just 1 line :)
include/sound/simple*card*
Best regards --- Kuninori Morimoto
On 23/08/16 12:09, Kuninori Morimoto wrote:
Hi Nicolas
include/sound/simple_card_utils.h is handled by ASoC maintainers, as stated in https://lkml.org/lkml/2016/8/22/307, and include/sound/simple_card.h seems to be an ASoC file too.
Signed-off-by: Nicolas Iooss nicolas.iooss_linux@m4x.org
MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS index 0bbe4b105c34..c840582d1439 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11012,6 +11012,8 @@ S: Supported F: Documentation/devicetree/bindings/sound/ F: Documentation/sound/alsa/soc/ F: sound/soc/ +F: include/sound/simple_card.h +F: include/sound/simple_card_utils.h F: include/sound/soc*
We will have more simple_xxx_card in the future I think. (I posted simple_scu_card, for example) So, how about this or similar ? It can be just 1 line :)
include/sound/simple*card*
I can't tell whether all files matching this pattern in the future will be supported by the ASoC maintainers, which is why I kept the full file names in my patch. Nevertheless if you are confident about this, I can modify the patch accordingly.
Thanks, Nicolas
The patch
ASoC: simple-card-utils: add __printf attribute
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From e5668caec5698f14f310fb06bb39595b21d2fe4a Mon Sep 17 00:00:00 2001
From: Nicolas Iooss nicolas.iooss_linux@m4x.org Date: Tue, 23 Aug 2016 10:51:22 +0200 Subject: [PATCH] ASoC: simple-card-utils: add __printf attribute
asoc_simple_card_set_dailink_name() uses devm_kvasprintf() to format some of its arguments. Adding a __printf attribute to this function makes it possible to detect at compile-time errors related to format strings.
Signed-off-by: Nicolas Iooss nicolas.iooss_linux@m4x.org Signed-off-by: Mark Brown broonie@kernel.org --- include/sound/simple_card_utils.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/include/sound/simple_card_utils.h b/include/sound/simple_card_utils.h index 403ec92164fc..fd6412551145 100644 --- a/include/sound/simple_card_utils.h +++ b/include/sound/simple_card_utils.h @@ -27,6 +27,7 @@ int asoc_simple_card_parse_daifmt(struct device *dev, struct device_node *codec, char *prefix, unsigned int *retfmt); +__printf(3, 4) int asoc_simple_card_set_dailink_name(struct device *dev, struct snd_soc_dai_link *dai_link, const char *fmt, ...);
participants (3)
-
Kuninori Morimoto -
Mark Brown -
Nicolas Iooss