Hi Arnd,

Thanks for your patch!

On Mon, Sep 20, 2021 at 12:02 PM Arnd Bergmann arnd@kernel.org wrote:

From: Arnd Bergmann arnd@arndb.de

Without CONFIG_COMMON_CLK, this driver fails to link:

ERROR: modpost: "clk_unregister_gate" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined! ERROR: modpost: "clk_register_gate" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined!

Add the proper Kconfig dependency for compile testing.

Fixes: 6746cc858259 ("ASoC: mediatek: mt8195: add platform driver") Fixes: 940ffa194547 ("ASoC: mediatek: SND_SOC_MT8195 should depend on ARCH_MEDIATEK")

I don't think the second Fixes tag is appropriate, as that commit did not relax the dependencies.

Signed-off-by: Arnd Bergmann arnd@arndb.de

sound/soc/mediatek/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig index 5a2f4667d50b..268c1f74aa3e 100644 --- a/sound/soc/mediatek/Kconfig +++ b/sound/soc/mediatek/Kconfig @@ -187,7 +187,7 @@ config SND_SOC_MT8192_MT6359_RT1015_RT5682

config SND_SOC_MT8195 tristate "ASoC support for Mediatek MT8195 chip"

•   depends on ARCH_MEDIATEK || COMPILE_TEST
  

•   depends on ARCH_MEDIATEK || (COMPILE_TEST && COMMON_CLK)
  

Why not add a second line

depends on COMMON_CLK

to make a clear distinction between hard and soft dependencies?

    select SND_SOC_MEDIATEK
    help
      This adds ASoC platform driver support for Mediatek MT8195 chip

Gr{oetje,eeting}s,

Geert