[alsa-devel] [PATCH] ALSA: core: Constify the name in new kcontrols
We never modify it and this lets us use a const string as the name without warnings.
Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com ---
I've got some ASoC patches which need this to avoid warnings, if you're OK with it can I apply it via there please?
include/sound/control.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/sound/control.h b/include/sound/control.h index b2796e8..57815f6 100644 --- a/include/sound/control.h +++ b/include/sound/control.h @@ -40,7 +40,7 @@ struct snd_kcontrol_new { snd_ctl_elem_iface_t iface; /* interface identifier */ unsigned int device; /* device/client number */ unsigned int subdevice; /* subdevice (substream) number */ - unsigned char *name; /* ASCII name of item */ + const unsigned char *name; /* ASCII name of item */ unsigned int index; /* index of item */ unsigned int access; /* access rights */ unsigned int count; /* count of same elements */
At Thu, 16 Feb 2012 17:09:09 -0800, Mark Brown wrote:
We never modify it and this lets us use a const string as the name without warnings.
Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com
I've got some ASoC patches which need this to avoid warnings, if you're OK with it can I apply it via there please?
Yeah, the new compile warnings by this change are only in sound/soc/*, so it makes sense to apply via asoc tree with proper fixes. In case it's needed, Reviewed-by: Takashi Iwai tiwai@suse.de
thanks,
Takashi
include/sound/control.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/sound/control.h b/include/sound/control.h index b2796e8..57815f6 100644 --- a/include/sound/control.h +++ b/include/sound/control.h @@ -40,7 +40,7 @@ struct snd_kcontrol_new { snd_ctl_elem_iface_t iface; /* interface identifier */ unsigned int device; /* device/client number */ unsigned int subdevice; /* subdevice (substream) number */
- unsigned char *name; /* ASCII name of item */
- const unsigned char *name; /* ASCII name of item */ unsigned int index; /* index of item */ unsigned int access; /* access rights */ unsigned int count; /* count of same elements */
-- 1.7.9.rc1
participants (2)
-
Mark Brown
-
Takashi Iwai