[alsa-devel] compress offload patch
Takashi, Vinod,
Can you help with merging the attached patch for compress offload core upstream?
Thanks.
Eric.
On Thu, 03 Mar 2016 17:09:52 +0100, Eric Laurent wrote:
Takashi, Vinod,
Can you help with merging the attached patch for compress offload core upstream?
Looks good to me, but I'm waiting for ack from Vinod.
BTW, I noticed that SNDRV_PCM_STREAM_PREPARED is missing in the comment in snd_compr_open(). Should be fixed in another patch.
thanks,
Takashi
Thanks.
Eric. [1.2 <text/html; UTF-8 (7bit)>]
From 1166adf4b63ea3ee1d119c46d97fa65c76a08447 Mon Sep 17 00:00:00 2001 From: Eric Laurent elaurent@google.com Date: Wed, 2 Mar 2016 09:54:57 -0800 Subject: [PATCH] ALSA: compress: allow writes in SNDRV_PCM_STATE_PREPARED state
Allow writes in SNDRV_PCM_STATE_PREPARED state so that more than one buffer fragment can be written from user space before calling SNDRV_COMPRESS_START.
Signed-off-by: Eric Laurent elaurent@google.com
sound/core/compress_offload.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c index 1b77852..7c57f37 100644 --- a/sound/core/compress_offload.c +++ b/sound/core/compress_offload.c @@ -281,6 +281,7 @@ static ssize_t snd_compr_write(struct file *f, const char __user *buf, mutex_lock(&stream->device->lock); /* write is allowed when stream is running or has been steup */ if (stream->runtime->state != SNDRV_PCM_STATE_SETUP &&
mutex_unlock(&stream->device->lock); return -EBADFD;stream->runtime->state != SNDRV_PCM_STATE_PREPARED && stream->runtime->state != SNDRV_PCM_STATE_RUNNING) {
-- 2.7.0.rc3.207.g0ac5344
On Fri, Mar 04, 2016 at 10:49:34AM +0100, Takashi Iwai wrote:
On Thu, 03 Mar 2016 17:09:52 +0100, Eric Laurent wrote:
Takashi, Vinod,
Can you help with merging the attached patch for compress offload core upstream?
Looks good to me, but I'm waiting for ack from Vinod.
Sounds good to me so:
Acked-by: Vinod Koul vinod.koul@intel.com
BTW, I noticed that SNDRV_PCM_STREAM_PREPARED is missing in the comment in snd_compr_open(). Should be fixed in another patch.
Yes will send that and noticed a typo, will fix both
Thanks
On Fri, 04 Mar 2016 14:52:00 +0100, Vinod Koul wrote:
On Fri, Mar 04, 2016 at 10:49:34AM +0100, Takashi Iwai wrote:
On Thu, 03 Mar 2016 17:09:52 +0100, Eric Laurent wrote:
Takashi, Vinod,
Can you help with merging the attached patch for compress offload core upstream?
Looks good to me, but I'm waiting for ack from Vinod.
Sounds good to me so:
Acked-by: Vinod Koul vinod.koul@intel.com
OK, merged now to for-next branch.
BTW, I noticed that SNDRV_PCM_STREAM_PREPARED is missing in the comment in snd_compr_open(). Should be fixed in another patch.
Yes will send that and noticed a typo, will fix both
Great, thanks.
Takashi
Thanks
On Fri, Mar 4, 2016 at 5:51 AM, Takashi Iwai tiwai@suse.de wrote:
On Fri, 04 Mar 2016 14:52:00 +0100, Vinod Koul wrote:
On Fri, Mar 04, 2016 at 10:49:34AM +0100, Takashi Iwai wrote:
On Thu, 03 Mar 2016 17:09:52 +0100, Eric Laurent wrote:
Takashi, Vinod,
Can you help with merging the attached patch for compress offload
core
upstream?
Looks good to me, but I'm waiting for ack from Vinod.
Sounds good to me so:
Acked-by: Vinod Koul vinod.koul@intel.com
OK, merged now to for-next branch.
BTW, I noticed that SNDRV_PCM_STREAM_PREPARED is missing in the comment in snd_compr_open(). Should be fixed in another patch.
Yes will send that and noticed a typo, will fix both
Great, thanks.
Takashi
participants (3)
-
Eric Laurent
-
Takashi Iwai
-
Vinod Koul