[PATCH] ASoC: stm32: fix unmet dependency on GPIOLIB for SND_SOC_DMIC
When SND_SOC_STM32_DFSDM is selected, and GPIOLIB is not selected, Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for SND_SOC_DMIC Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n] Selected by [y]: - SND_SOC_STM32_DFSDM [=y] && SOUND [=y] && !UML && SND [=y] && (ARCH_STM32 || COMPILE_TEST [=y]) && SND_SOC [=y] && STM32_DFSDM_ADC [=y]
This is because SND_SOC_STM32_DFSDM selects SND_SOC_DMIC without selecting or depending on GPIOLIB, despite SND_SOC_DMIC depending on GPIOLIB.
This unmet dependency bug was detected by Kismet, a static analysis tool for Kconfig. Please advise if this is not the appropriate solution.
Signed-off-by: Julian Braha julianbraha@gmail.com --- sound/soc/stm/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/soc/stm/Kconfig b/sound/soc/stm/Kconfig index da1f7a16605b..bfc11b606bbd 100644 --- a/sound/soc/stm/Kconfig +++ b/sound/soc/stm/Kconfig @@ -37,6 +37,7 @@ config SND_SOC_STM32_DFSDM depends on ARCH_STM32 || COMPILE_TEST depends on SND_SOC depends on STM32_DFSDM_ADC + depends on GPIOLIB select SND_SOC_GENERIC_DMAENGINE_PCM select SND_SOC_DMIC select IIO_BUFFER_CB
participants (1)
-
Julian Braha