[alsa-devel] [PATCH] ALSA: intel_hda - Add dock support for ThinkPad X260
Hi! My shiny new ThinkPad X260 is the same way affected, as older ThinkPad (X*40, X*50) generations. That means, I am unable to get sound output, when I am using the Lenovo CES 2013 docking station series (basic, pro, ultra).
It can be fixed the same way, as it was already done for X240 and X250, as the X260 uses the same docking connector. I am attaching my patch, which works for me.
Cheers Conrad
------------------------------
Fixes audio output on a ThinkPad X260, when using Lenovo CES 2013 docking station series (basic, pro, ultra).
Signed-off-by: Conrad Kostecki ck+linuxkernel@bl4ckb0x.de
diff -uprN -X linux-4.6-rc4-vanilla/Documentation/dontdiff linux-4.6-rc4-vanilla/sound/pci/hda/patch_realtek.c linux-4.6-rc4/sound/pci/hda/patch_realtek.c --- linux-4.6-rc4-vanilla/sound/pci/hda/patch_realtek.c 2016-04-24 03:26:36.330983586 +0200 +++ linux-4.6-rc4/sound/pci/hda/patch_realtek.c 2016-04-24 03:27:13.737981843 +0200 @@ -5570,6 +5570,7 @@ static const struct snd_pci_quirk alc269 SND_PCI_QUIRK(0x17aa, 0x2218, "Thinkpad X1 Carbon 2nd", ALC292_FIXUP_TPT440_DOCK), SND_PCI_QUIRK(0x17aa, 0x2223, "ThinkPad T550", ALC292_FIXUP_TPT440_DOCK), SND_PCI_QUIRK(0x17aa, 0x2226, "ThinkPad X250", ALC292_FIXUP_TPT440_DOCK), + SND_PCI_QUIRK(0x17aa, 0x504a, "ThinkPad X260", ALC292_FIXUP_TPT440_DOCK), SND_PCI_QUIRK(0x17aa, 0x2233, "Thinkpad", ALC292_FIXUP_TPT460), SND_PCI_QUIRK(0x17aa, 0x30bb, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY), SND_PCI_QUIRK(0x17aa, 0x30e2, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY), ------------------------------
-- To unsubscribe from this list: send the line "unsubscribe alsa-devel" in
On Sun, 24 Apr 2016 03:48:21 +0200, Conrad Kostecki wrote:
Hi! My shiny new ThinkPad X260 is the same way affected, as older ThinkPad (X*40, X*50) generations. That means, I am unable to get sound output, when I am using the Lenovo CES 2013 docking station series (basic, pro, ultra).
It can be fixed the same way, as it was already done for X240 and X250, as the X260 uses the same docking connector. I am attaching my patch, which works for me.
Thanks, applied now with a minor modification (adding the entry at the right place; it's sorted in the order of SSID).
Takashi
Cheers Conrad
Fixes audio output on a ThinkPad X260, when using Lenovo CES 2013 docking station series (basic, pro, ultra).
Signed-off-by: Conrad Kostecki ck+linuxkernel@bl4ckb0x.de
diff -uprN -X linux-4.6-rc4-vanilla/Documentation/dontdiff linux-4.6-rc4-vanilla/sound/pci/hda/patch_realtek.c linux-4.6-rc4/sound/pci/hda/patch_realtek.c --- linux-4.6-rc4-vanilla/sound/pci/hda/patch_realtek.c 2016-04-24 03:26:36.330983586 +0200 +++ linux-4.6-rc4/sound/pci/hda/patch_realtek.c 2016-04-24 03:27:13.737981843 +0200 @@ -5570,6 +5570,7 @@ static const struct snd_pci_quirk alc269 SND_PCI_QUIRK(0x17aa, 0x2218, "Thinkpad X1 Carbon 2nd", ALC292_FIXUP_TPT440_DOCK), SND_PCI_QUIRK(0x17aa, 0x2223, "ThinkPad T550", ALC292_FIXUP_TPT440_DOCK), SND_PCI_QUIRK(0x17aa, 0x2226, "ThinkPad X250", ALC292_FIXUP_TPT440_DOCK),
SND_PCI_QUIRK(0x17aa, 0x504a, "ThinkPad X260",ALC292_FIXUP_TPT440_DOCK), SND_PCI_QUIRK(0x17aa, 0x2233, "Thinkpad", ALC292_FIXUP_TPT460), SND_PCI_QUIRK(0x17aa, 0x30bb, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY), SND_PCI_QUIRK(0x17aa, 0x30e2, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
-- To unsubscribe from this list: send the line "unsubscribe alsa-devel" in
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Takashi Iwai tiwai@suse.de hat am 26. April 2016 um 10:16 geschrieben:
On Sun, 24 Apr 2016 03:48:21 +0200, Conrad Kostecki wrote:
Hi! My shiny new ThinkPad X260 is the same way affected, as older ThinkPad (X*40, X*50) generations. That means, I am unable to get sound output, when I am using the Lenovo CES 2013 docking station series (basic, pro, ultra).
It can be fixed the same way, as it was already done for X240 and X250, as the X260 uses the same docking connector. I am attaching my patch, which works for me.
Thanks, applied now with a minor modification (adding the entry at the right place; it's sorted in the order of SSID).
Thank you! :) Will be this also included in 4.6?
On Tue, 26 Apr 2016 12:12:39 +0200, Conrad Kostecki wrote:
Takashi Iwai tiwai@suse.de hat am 26. April 2016 um 10:16 geschrieben:
On Sun, 24 Apr 2016 03:48:21 +0200, Conrad Kostecki wrote:
Hi! My shiny new ThinkPad X260 is the same way affected, as older ThinkPad (X*40, X*50) generations. That means, I am unable to get sound output, when I am using the Lenovo CES 2013 docking station series (basic, pro, ultra).
It can be fixed the same way, as it was already done for X240 and X250, as the X260 uses the same docking connector. I am attaching my patch, which works for me.
Thanks, applied now with a minor modification (adding the entry at the right place; it's sorted in the order of SSID).
Thank you! :) Will be this also included in 4.6?
Yes, likely in the next rc.
Takashi
participants (2)
-
Conrad Kostecki -
Takashi Iwai