[alsa-devel] [PATCH 4/5 v1] ASoC adds destination and source port for dma
Adds destination and source port for dma in platform driver as required by OMAP1
Signed-off-by: Arun KS arunks@mistralsolutions.com --- sound/soc/omap/omap-pcm.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c index 690bfea..e9084fd 100644 --- a/sound/soc/omap/omap-pcm.c +++ b/sound/soc/omap/omap-pcm.c @@ -97,7 +97,7 @@ static int omap_pcm_hw_params(struct snd_pcm_substream *substream, prtd->dma_data = dma_data; err = omap_request_dma(dma_data->dma_req, dma_data->name, omap_pcm_dma_irq, substream, &prtd->dma_ch); - if (!cpu_is_omap1510()) { + if (!err & !cpu_is_omap1510()) { /* * Link channel with itself so DMA doesn't need any * reprogramming while looping the buffer @@ -147,12 +147,14 @@ static int omap_pcm_prepare(struct snd_pcm_substream *substream) dma_params.src_or_dst_synch = OMAP_DMA_DST_SYNC; dma_params.src_start = runtime->dma_addr; dma_params.dst_start = dma_data->port_addr; + dma_params.dst_port = OMAP_DMA_PORT_MPUI; } else { dma_params.src_amode = OMAP_DMA_AMODE_CONSTANT; dma_params.dst_amode = OMAP_DMA_AMODE_POST_INC; dma_params.src_or_dst_synch = OMAP_DMA_SRC_SYNC; dma_params.src_start = dma_data->port_addr; dma_params.dst_start = runtime->dma_addr; + dma_params.src_port = OMAP_DMA_PORT_MPUI; } /* * Set DMA transfer frame size equal to ALSA period size and frame
On Tue, Sep 30, 2008 at 03:35:16PM +0530, Arun KS wrote:
@@ -147,12 +147,14 @@ static int omap_pcm_prepare(struct snd_pcm_substream *substream)
Yup, these are definitely being word wrapped by your mailer so they won't apply without massaging. If you can't configure your normal MUA to send them through cleanly you might want to look into git send-email or the quilt equivalent both of which are specifically designed to handle patches.
You can test this by mailing the patches to yourself and then trying to apply them.
Anyway, the patch looks OK:
Acked-by: Mark Brown broonie@opensource.wolfsonmicro.com
On Tue, 30 Sep 2008 11:23:38 +0100 "ext Mark Brown" broonie@sirena.org.uk wrote:
On Tue, Sep 30, 2008 at 03:35:16PM +0530, Arun KS wrote:
@@ -147,12 +147,14 @@ static int omap_pcm_prepare(struct snd_pcm_substream *substream)
Yup, these are definitely being word wrapped by your mailer so they won't apply without massaging. If you can't configure your normal MUA to send them through cleanly you might want to look into git send-email or the quilt equivalent both of which are specifically designed to handle patches.
You can test this by mailing the patches to yourself and then trying to apply them.
Anyway, the patch looks OK:
Acked-by: Mark Brown broonie@opensource.wolfsonmicro.com
Probably commit can mention the fix done but ok from my side.
Acked-by: Jarkko Nikula jarkko.nikula@nokia.com
participants (3)
-
Arun KS -
Jarkko Nikula -
Mark Brown