[alsa-devel] [PATCH -next] soc: sgtl5000 uses regulator interfaces
From: Randy Dunlap randy.dunlap@oracle.com
sgtl5000 uses regulator interfaces, so make selecting it depend on REGULATOR.
sgtl5000.c:(.text+0x4ae33): undefined reference to `regulator_unregister' sgtl5000.c:(.text+0x4af41): undefined reference to `rdev_get_drvdata' sgtl5000.c:(.text+0x4b191): undefined reference to `regulator_register'
Signed-off-by: Randy Dunlap randy.dunlap@oracle.com Cc: Zeng Zhaoming zhaoming.zeng@freescale.com --- sound/soc/codecs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20110304.orig/sound/soc/codecs/Kconfig +++ linux-next-20110304/sound/soc/codecs/Kconfig @@ -33,7 +33,7 @@ config SND_SOC_ALL_CODECS select SND_SOC_MAX98088 if I2C select SND_SOC_MAX9877 if I2C select SND_SOC_PCM3008 - select SND_SOC_SGTL5000 if I2C + select SND_SOC_SGTL5000 if I2C && REGULATOR select SND_SOC_SN95031 if INTEL_SCU_IPC select SND_SOC_SPDIF select SND_SOC_SSM2602 if I2C
On Fri, Mar 04, 2011 at 05:33:57PM -0800, Randy Dunlap wrote:
From: Randy Dunlap randy.dunlap@oracle.com
sgtl5000 uses regulator interfaces, so make selecting it depend on REGULATOR.
sgtl5000.c:(.text+0x4ae33): undefined reference to `regulator_unregister' sgtl5000.c:(.text+0x4af41): undefined reference to `rdev_get_drvdata' sgtl5000.c:(.text+0x4b191): undefined reference to `regulator_register'
Since the regulator on the device is optional this isn't the best fix, the code should be updated to support building without regulator.
On Sat, Mar 5, 2011 at 7:29 PM, Mark Brown broonie@opensource.wolfsonmicro.com wrote:
On Fri, Mar 04, 2011 at 05:33:57PM -0800, Randy Dunlap wrote:
From: Randy Dunlap randy.dunlap@oracle.com
sgtl5000 uses regulator interfaces, so make selecting it depend on REGULATOR.
sgtl5000.c:(.text+0x4ae33): undefined reference to `regulator_unregister' sgtl5000.c:(.text+0x4af41): undefined reference to `rdev_get_drvdata' sgtl5000.c:(.text+0x4b191): undefined reference to `regulator_register'
hi， Thanks for the report.
Since the regulator on the device is optional this isn't the best fix, the code should be updated to support building without regulator.
I will fix the code. If regulator not enabled, and the optional regulator not provided externally, a warning message will print out, and internal regulator will set directly by write register.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
On Sat, 5 Mar 2011 20:41:38 +0800 Zeng Zhaoming wrote:
On Sat, Mar 5, 2011 at 7:29 PM, Mark Brown broonie@opensource.wolfsonmicro.com wrote:
On Fri, Mar 04, 2011 at 05:33:57PM -0800, Randy Dunlap wrote:
From: Randy Dunlap randy.dunlap@oracle.com
sgtl5000 uses regulator interfaces, so make selecting it depend on REGULATOR.
sgtl5000.c:(.text+0x4ae33): undefined reference to `regulator_unregister' sgtl5000.c:(.text+0x4af41): undefined reference to `rdev_get_drvdata' sgtl5000.c:(.text+0x4b191): undefined reference to `regulator_register'
hi， Thanks for the report.
Since the regulator on the device is optional this isn't the best fix, the code should be updated to support building without regulator.
I will fix the code. If regulator not enabled, and the optional regulator not provided externally, a warning message will print out, and internal regulator will set directly by write register.
--
ping. This build error still happens in linux-next 2011.0315.
--- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
participants (3)
-
Mark Brown -
Randy Dunlap -
Zeng Zhaoming