[alsa-devel] [PATCH 1/2] ASoC: cs35l32: Remove unneeded regulator_bulk_free call in cs35l32_i2c_remove
The regulator_bulk_free() call is not required because current code is using devm_regulator_bulk_get().
Signed-off-by: Axel Lin axel.lin@ingics.com --- sound/soc/codecs/cs35l32.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/sound/soc/codecs/cs35l32.c b/sound/soc/codecs/cs35l32.c index 380c212..718569f 100644 --- a/sound/soc/codecs/cs35l32.c +++ b/sound/soc/codecs/cs35l32.c @@ -548,8 +548,6 @@ static int cs35l32_i2c_remove(struct i2c_client *i2c_client) if (cs35l32->reset_gpio) gpiod_set_value_cansleep(cs35l32->reset_gpio, 0);
- regulator_bulk_free(ARRAY_SIZE(cs35l32->supplies), cs35l32->supplies); - return 0; }
The regulator_bulk_free() call is not required because current code is using devm_regulator_bulk_get().
Signed-off-by: Axel Lin axel.lin@ingics.com --- sound/soc/codecs/cs42l56.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/sound/soc/codecs/cs42l56.c b/sound/soc/codecs/cs42l56.c index c766a5a..5a2d732 100644 --- a/sound/soc/codecs/cs42l56.c +++ b/sound/soc/codecs/cs42l56.c @@ -1175,11 +1175,8 @@ static int cs42l56_probe(struct snd_soc_codec *codec)
static int cs42l56_remove(struct snd_soc_codec *codec) { - struct cs42l56_private *cs42l56 = snd_soc_codec_get_drvdata(codec); - cs42l56_free_beep(codec); cs42l56_set_bias_level(codec, SND_SOC_BIAS_OFF); - regulator_bulk_free(ARRAY_SIZE(cs42l56->supplies), cs42l56->supplies);
return 0; }
On Thu, 28 Aug 2014, Axel Lin wrote:
The regulator_bulk_free() call is not required because current code is using devm_regulator_bulk_get().
Signed-off-by: Axel Lin axel.lin@ingics.com
sound/soc/codecs/cs42l56.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/sound/soc/codecs/cs42l56.c b/sound/soc/codecs/cs42l56.c index c766a5a..5a2d732 100644 --- a/sound/soc/codecs/cs42l56.c +++ b/sound/soc/codecs/cs42l56.c @@ -1175,11 +1175,8 @@ static int cs42l56_probe(struct snd_soc_codec *codec)
static int cs42l56_remove(struct snd_soc_codec *codec) {
struct cs42l56_private *cs42l56 = snd_soc_codec_get_drvdata(codec);
cs42l56_free_beep(codec); cs42l56_set_bias_level(codec, SND_SOC_BIAS_OFF);
regulator_bulk_free(ARRAY_SIZE(cs42l56->supplies), cs42l56->supplies);
return 0;
}
Thanks Axel,
For the series..
Acked-by: Brian Austin brian.austin@cirrus.com
participants (3)
-
Axel Lin -
Brian Austin -
Mark Brown