[alsa-devel] [PATCH] ALSA: hdac: Explicitly add io.h
Compiling the hdac extended core on arm fails with below error:
sound/hda/ext/hdac_ext_bus.c: In function 'hdac_ext_writel':
sound/hda/ext/hdac_ext_bus.c:29:2: error: implicit declaration of function
+'writel' [-Werror=implicit-function-declaration] writel(value, addr); ^ sound/hda/ext/hdac_ext_bus.c: In function 'hdac_ext_readl':
sound/hda/ext/hdac_ext_bus.c:34:2: error: implicit declaration of function
+'readl' [-Werror=implicit-function-declaration] return readl(addr);
This is fixed by explicitly including io.h
Fixes: 99463b3a3994 - ('ALSA: hda: provide default bus io ops extended hdac') Reported-by: kbuild test robot lkp@intel.com Suggested-by: Mark Brown broonie@kernel.org Signed-off-by: Vinod Koul vinod.koul@intel.com --- sound/hda/ext/hdac_ext_bus.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/hda/ext/hdac_ext_bus.c b/sound/hda/ext/hdac_ext_bus.c index 4449d1a99089..2433f7c81472 100644 --- a/sound/hda/ext/hdac_ext_bus.c +++ b/sound/hda/ext/hdac_ext_bus.c @@ -19,6 +19,7 @@
#include <linux/module.h> #include <linux/slab.h> +#include <linux/io.h> #include <sound/hdaudio_ext.h>
MODULE_DESCRIPTION("HDA extended core");
On Tue, 13 Oct 2015 11:27:49 +0200, Vinod Koul wrote:
Compiling the hdac extended core on arm fails with below error:
sound/hda/ext/hdac_ext_bus.c: In function 'hdac_ext_writel':
sound/hda/ext/hdac_ext_bus.c:29:2: error: implicit declaration of function
+'writel' [-Werror=implicit-function-declaration] writel(value, addr); ^ sound/hda/ext/hdac_ext_bus.c: In function 'hdac_ext_readl':
sound/hda/ext/hdac_ext_bus.c:34:2: error: implicit declaration of function
+'readl' [-Werror=implicit-function-declaration] return readl(addr);
This is fixed by explicitly including io.h
Fixes: 99463b3a3994 - ('ALSA: hda: provide default bus io ops extended hdac') Reported-by: kbuild test robot lkp@intel.com Suggested-by: Mark Brown broonie@kernel.org Signed-off-by: Vinod Koul vinod.koul@intel.com
Applied, thanks.
Takashi
sound/hda/ext/hdac_ext_bus.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/hda/ext/hdac_ext_bus.c b/sound/hda/ext/hdac_ext_bus.c index 4449d1a99089..2433f7c81472 100644 --- a/sound/hda/ext/hdac_ext_bus.c +++ b/sound/hda/ext/hdac_ext_bus.c @@ -19,6 +19,7 @@
#include <linux/module.h> #include <linux/slab.h> +#include <linux/io.h> #include <sound/hdaudio_ext.h>
MODULE_DESCRIPTION("HDA extended core");
2.4.3
participants (2)
-
Takashi Iwai
-
Vinod Koul