Re: [alsa-devel] [PATCH] ASoC: make ops a pointer in 'struct snd_soc_dai'
Eric Miao wrote:
Updated as below, (gzip version attached due to mailing list mail size limitation).
From 74a2b6dfff2948d9d04b33d0a02f645f8c12caf7 Mon Sep 17 00:00:00 2001 From: Eric Miao eric.miao@marvell.com Date: Mon, 2 Mar 2009 22:38:31 +0800 Subject: [PATCH] ASoC: make ops a pointer of 'struct snd_soc_dai'
Considering the fact that most cpu_dai or codec_dai are using a same 'snd_soc_dai_ops' for several similar interfaces, 'ops' would be better made a pointer instead, to make sharing easier and code a bit cleaner.
The patch below is rather preliminary since the asoc tree is being actively developed, and this touches almost every piece of code, (and possibly many others in development need to be changed as well). Building of all codecs are OK, yet to every SoC, I didn't test that.
Signed-off-by: Eric Miao eric.miao@marvell.com
Tested on an MPC8610 HPCD, and it works. That's all I can vouch for, though.
Acked-by: Timur Tabi timur@freescale.com
On Thu, Mar 5, 2009 at 5:32 AM, Timur Tabi timur@freescale.com wrote:
Eric Miao wrote:
Updated as below, (gzip version attached due to mailing list mail size limitation).
From 74a2b6dfff2948d9d04b33d0a02f645f8c12caf7 Mon Sep 17 00:00:00 2001 From: Eric Miao eric.miao@marvell.com Date: Mon, 2 Mar 2009 22:38:31 +0800 Subject: [PATCH] ASoC: make ops a pointer of 'struct snd_soc_dai'
Considering the fact that most cpu_dai or codec_dai are using a same 'snd_soc_dai_ops' for several similar interfaces, 'ops' would be better made a pointer instead, to make sharing easier and code a bit cleaner.
The patch below is rather preliminary since the asoc tree is being actively developed, and this touches almost every piece of code, (and possibly many others in development need to be changed as well). Building of all codecs are OK, yet to every SoC, I didn't test that.
Signed-off-by: Eric Miao eric.miao@marvell.com
Tested on an MPC8610 HPCD, and it works. That's all I can vouch for, though.
Acked-by: Timur Tabi timur@freescale.com
Thanks.
participants (2)
-
Eric Miao -
Timur Tabi