[alsa-devel] [sound:for-next 48/48] sound/usb/line6/driver.c:484:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next head: a16039cbf1a1ee7e76d7d100f9e613998919ab91 commit: a16039cbf1a1ee7e76d7d100f9e613998919ab91 [48/48] ALSA: line6: Add hwdep interface to access the POD control messages
coccinelle warnings: (new ones prefixed by >>)
sound/usb/line6/driver.c:484:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
Please review and possibly fold the followup patch.
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
sound/usb/line6/driver.c:484:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
NULL check before some freeing functions is not needed.
Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
CC: Andrej Krutak dev@andree.sk Signed-off-by: Fengguang Wu fengguang.wu@intel.com ---
driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
--- a/sound/usb/line6/driver.c +++ b/sound/usb/line6/driver.c @@ -480,8 +480,7 @@ static void line6_destruct(struct snd_ca /* Free buffer memory first. We cannot depend on the existence of private * data from the (podhd) module, it may be gone already during this call */ - if (line6->buffer_message) - kfree(line6->buffer_message); + kfree(line6->buffer_message);
kfree(line6->buffer_listen);
On Tue, 20 Sep 2016 02:10:13 +0200, kbuild test robot wrote:
sound/usb/line6/driver.c:484:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
NULL check before some freeing functions is not needed.
Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
CC: Andrej Krutak dev@andree.sk Signed-off-by: Fengguang Wu fengguang.wu@intel.com
Applied, thanks.
Takashi
driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
--- a/sound/usb/line6/driver.c +++ b/sound/usb/line6/driver.c @@ -480,8 +480,7 @@ static void line6_destruct(struct snd_ca /* Free buffer memory first. We cannot depend on the existence of private * data from the (podhd) module, it may be gone already during this call */
- if (line6->buffer_message)
kfree(line6->buffer_message);
kfree(line6->buffer_message);
kfree(line6->buffer_listen);
participants (2)
-
kbuild test robot -
Takashi Iwai