[alsa-devel] [PATCH 07/10] mfd: madera: point to the right pinctrl binding file
The reference to Documentation/pinctrl.txt doesn't exist, but there is an specific binding for the madera driver.
So, point to it.
Signed-off-by: Mauro Carvalho Chehab mchehab+samsung@kernel.org --- include/linux/mfd/madera/pdata.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/mfd/madera/pdata.h b/include/linux/mfd/madera/pdata.h index 8dc852402dbb..c7e0658eb74b 100644 --- a/include/linux/mfd/madera/pdata.h +++ b/include/linux/mfd/madera/pdata.h @@ -34,7 +34,8 @@ struct madera_codec_pdata; * @micvdd: Substruct of pdata for the MICVDD regulator * @irq_flags: Mode for primary IRQ (defaults to active low) * @gpio_base: Base GPIO number - * @gpio_configs: Array of GPIO configurations (See Documentation/pinctrl.txt) + * @gpio_configs: Array of GPIO configurations + * (See Documentation/devicetree/bindings/pinctrl/cirrus,madera-pinctrl.txt) * @n_gpio_configs: Number of entries in gpio_configs * @gpsw: General purpose switch mode setting. Depends on the external * hardware connected to the switch. (See the SW1_MODE field
On Mon, May 20, 2019 at 11:47:36AM -0300, Mauro Carvalho Chehab wrote:
The reference to Documentation/pinctrl.txt doesn't exist, but there is an specific binding for the madera driver.
So, point to it.
Signed-off-by: Mauro Carvalho Chehab mchehab+samsung@kernel.org
include/linux/mfd/madera/pdata.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/mfd/madera/pdata.h b/include/linux/mfd/madera/pdata.h index 8dc852402dbb..c7e0658eb74b 100644 --- a/include/linux/mfd/madera/pdata.h +++ b/include/linux/mfd/madera/pdata.h @@ -34,7 +34,8 @@ struct madera_codec_pdata;
- @micvdd: Substruct of pdata for the MICVDD regulator
- @irq_flags: Mode for primary IRQ (defaults to active low)
- @gpio_base: Base GPIO number
- @gpio_configs: Array of GPIO configurations (See Documentation/pinctrl.txt)
- @gpio_configs: Array of GPIO configurations
(See Documentation/devicetree/bindings/pinctrl/cirrus,madera-pinctrl.txt)
I believe this is trying to point at the generic pinctrl docs which now live here:
Documentation/driver-api/pinctl.rst
There is a patch to do this already: https://lkml.org/lkml/2019/1/9/853 With the latest resend here: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2001752.html
Thanks, Charles
- @n_gpio_configs: Number of entries in gpio_configs
- @gpsw: General purpose switch mode setting. Depends on the external
hardware connected to the switch. (See the SW1_MODE field
-- 2.21.0
Em Mon, 20 May 2019 16:42:45 +0100 Charles Keepax ckeepax@opensource.cirrus.com escreveu:
On Mon, May 20, 2019 at 11:47:36AM -0300, Mauro Carvalho Chehab wrote:
The reference to Documentation/pinctrl.txt doesn't exist, but there is an specific binding for the madera driver.
So, point to it.
Signed-off-by: Mauro Carvalho Chehab mchehab+samsung@kernel.org
include/linux/mfd/madera/pdata.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/mfd/madera/pdata.h b/include/linux/mfd/madera/pdata.h index 8dc852402dbb..c7e0658eb74b 100644 --- a/include/linux/mfd/madera/pdata.h +++ b/include/linux/mfd/madera/pdata.h @@ -34,7 +34,8 @@ struct madera_codec_pdata;
- @micvdd: Substruct of pdata for the MICVDD regulator
- @irq_flags: Mode for primary IRQ (defaults to active low)
- @gpio_base: Base GPIO number
- @gpio_configs: Array of GPIO configurations (See Documentation/pinctrl.txt)
- @gpio_configs: Array of GPIO configurations
(See Documentation/devicetree/bindings/pinctrl/cirrus,madera-pinctrl.txt)
I believe this is trying to point at the generic pinctrl docs which now live here:
Documentation/driver-api/pinctl.rst
There is a patch to do this already: https://lkml.org/lkml/2019/1/9/853 With the latest resend here: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2001752.html
Ah, makes sense to me.
Please ignore this one.
Thanks, Mauro
participants (2)
-
Charles Keepax
-
Mauro Carvalho Chehab