Re: [alsa-devel] Audio support for TLV320AIC23 on Simtec S3C24XX products
On Thu, Aug 13, 2009 at 02:24:30PM +0100, Ben Dooks wrote:
Mark Brown wrote:
Also, as I've mentioned to you on a number of previous occasions please do try to remember to CC subsystem maintainers when submitting patches.
I thought you where the ASoC maintainer? Who else should I be CC'ing?
You'd only sent the patches to the list, there wasn't a CC to me.
So I'm guessing that this is muting through powering off? In that case (and probably in general) this would be better implemented as a DAPM widget with a SND_SOC_DAPM_PIN_SWITCH() control set up to provide the mute functionality. Doing this will allow the speaker to be powered off when no audio is being played, saving power and helping avoid any pops or clicks being amplified by it.
I tried it that way first, unfortunately the AMP itself makes a POP when powering up and down, the headphone output of the TLV320AIC23 doesn't seem to have a problem with pops.
But it doesn't pop when people use the mute control? OK, anyway.
On Thu, Aug 13, 2009 at 02:40:22PM +0100, Mark Brown wrote:
On Thu, Aug 13, 2009 at 02:24:30PM +0100, Ben Dooks wrote:
Mark Brown wrote:
Also, as I've mentioned to you on a number of previous occasions please do try to remember to CC subsystem maintainers when submitting patches.
I thought you where the ASoC maintainer? Who else should I be CC'ing?
You'd only sent the patches to the list, there wasn't a CC to me.
sorry, you are right about that.
So I'm guessing that this is muting through powering off? In that case (and probably in general) this would be better implemented as a DAPM widget with a SND_SOC_DAPM_PIN_SWITCH() control set up to provide the mute functionality. Doing this will allow the speaker to be powered off when no audio is being played, saving power and helping avoid any pops or clicks being amplified by it.
I tried it that way first, unfortunately the AMP itself makes a POP when powering up and down, the headphone output of the TLV320AIC23 doesn't seem to have a problem with pops.
But it doesn't pop when people use the mute control? OK, anyway. _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
participants (2)
-
Ben Dooks -
Mark Brown