[alsa-devel] [PATCH] ASoC AC97 device reg bugfix
This patch fixes a bug whereby AC97 bus device data was being clobbered when AC97 codecs using the generic ac97_codec.c driver were being registered. Codecs that didn't use the generic driver were unaffected (e.g. WM9712, WM9713).
Changes:-
o Add new AC97 codec class for custom (or need bus dev registration) AC97 codecs. o Only register/deregister this custom codec device with the AC97 bus. The generic AC97 driver already does this for generic codec devices.
This may be related to bug #3038 :-
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3038
Manuel, can you try this on SH & Au1x00.
Thanks
Liam
At Thu, 10 May 2007 17:28:33 +0100, Liam Girdwood wrote:
This patch fixes a bug whereby AC97 bus device data was being clobbered when AC97 codecs using the generic ac97_codec.c driver were being registered. Codecs that didn't use the generic driver were unaffected (e.g. WM9712, WM9713).
Changes:-
o Add new AC97 codec class for custom (or need bus dev registration) AC97 codecs. o Only register/deregister this custom codec device with the AC97 bus. The generic AC97 driver already does this for generic codec devices.
This may be related to bug #3038 :-
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3038
Manuel, can you try this on SH & Au1x00.
Is this supposed to be merged to the upstream? Then give a sign-off, please.
thanks,
Takashi
On Thu, 2007-05-10 at 18:32 +0200, Takashi Iwai wrote:
At Thu, 10 May 2007 17:28:33 +0100, Liam Girdwood wrote:
This patch fixes a bug whereby AC97 bus device data was being clobbered when AC97 codecs using the generic ac97_codec.c driver were being registered. Codecs that didn't use the generic driver were unaffected (e.g. WM9712, WM9713).
Changes:-
o Add new AC97 codec class for custom (or need bus dev registration) AC97 codecs. o Only register/deregister this custom codec device with the AC97 bus. The generic AC97 driver already does this for generic codec devices.
This may be related to bug #3038 :-
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3038
Manuel, can you try this on SH & Au1x00.
Is this supposed to be merged to the upstream? Then give a sign-off, please.
Signed-off-by: Liam Girdwood lg@opensource.wolfsonmicro.com
Thanks
Liam
On Thu, May 10, 2007 at 05:28:33PM +0100, Liam Girdwood wrote:
This patch fixes a bug whereby AC97 bus device data was being clobbered when AC97 codecs using the generic ac97_codec.c driver were being registered. Codecs that didn't use the generic driver were unaffected (e.g. WM9712, WM9713).
Changes:-
This may be related to bug #3038 :-
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3038
Manuel, can you try this on SH & Au1x00.
Yes, its fixed on both, thank you very much!
Manuel Lauss
participants (3)
-
Liam Girdwood
-
Manuel Lauss
-
Takashi Iwai