Re: [alsa-devel] [PATCH 2/3] ALSA - hda: Add support for link audio time reporting
On Mon, Jul 11, 2016 at 07:43:25PM +0800, kbuild test robot wrote:
Hi,
[auto build test ERROR on sound/for-next] [also build test ERROR on v4.7-rc7 next-20160711] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Vinod-Koul/ALSA-hda-Add-support-for... base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next config: arm-multi_v7_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/ma... -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=arm
All errors (new ones prefixed by >>):
sound/pci/hda/hda_controller.c:30:21: fatal error: asm/tsc.h: No such file or directory
compilation terminated.
Okay i think I need to move this bit into the intel code.
Takashi, I didnt see any X86 depends on SND_HDA_INTEL. I think we should add this now. Are you okay with that?
Thanks
24 #include <linux/delay.h> 25 #include <linux/interrupt.h> 26 #include <linux/kernel.h> 27 #include <linux/module.h> 28 #include <linux/pm_runtime.h> 29 #include <linux/slab.h>30 #include <asm/tsc.h>
31 #include <sound/core.h> 32 #include <sound/initval.h> 33 #include "hda_controller.h"
On Fri, 15 Jul 2016 06:37:21 +0200, Vinod Koul wrote:
On Mon, Jul 11, 2016 at 07:43:25PM +0800, kbuild test robot wrote:
Hi,
[auto build test ERROR on sound/for-next] [also build test ERROR on v4.7-rc7 next-20160711] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Vinod-Koul/ALSA-hda-Add-support-for... base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next config: arm-multi_v7_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/ma... -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=arm
All errors (new ones prefixed by >>):
sound/pci/hda/hda_controller.c:30:21: fatal error: asm/tsc.h: No such file or directory
compilation terminated.
Okay i think I need to move this bit into the intel code.
Takashi, I didnt see any X86 depends on SND_HDA_INTEL. I think we should add this now. Are you okay with that?
Better to have an explicit ifdef CONFIG_X86 around it. It's not only for x86.
Takashi
On Fri, Jul 15, 2016 at 07:00:41AM +0200, Takashi Iwai wrote:
On Fri, 15 Jul 2016 06:37:21 +0200, Vinod Koul wrote:
On Mon, Jul 11, 2016 at 07:43:25PM +0800, kbuild test robot wrote:
Hi,
[auto build test ERROR on sound/for-next] [also build test ERROR on v4.7-rc7 next-20160711] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Vinod-Koul/ALSA-hda-Add-support-for... base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next config: arm-multi_v7_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/ma... -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=arm
All errors (new ones prefixed by >>):
sound/pci/hda/hda_controller.c:30:21: fatal error: asm/tsc.h: No such file or directory
compilation terminated.
Okay i think I need to move this bit into the intel code.
Takashi, I didnt see any X86 depends on SND_HDA_INTEL. I think we should add this now. Are you okay with that?
Better to have an explicit ifdef CONFIG_X86 around it. It's not only for x86.
Need it around the whole of the timestamp code as well then..
Yes the HDA controller is not x86 specfic, but the hda-intel should be, right? This would make me move all this code into hda_intel.c as well..
On Fri, 15 Jul 2016 07:19:06 +0200, Vinod Koul wrote:
On Fri, Jul 15, 2016 at 07:00:41AM +0200, Takashi Iwai wrote:
On Fri, 15 Jul 2016 06:37:21 +0200, Vinod Koul wrote:
On Mon, Jul 11, 2016 at 07:43:25PM +0800, kbuild test robot wrote:
Hi,
[auto build test ERROR on sound/for-next] [also build test ERROR on v4.7-rc7 next-20160711] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Vinod-Koul/ALSA-hda-Add-support-for... base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next config: arm-multi_v7_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/ma... -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=arm
All errors (new ones prefixed by >>):
sound/pci/hda/hda_controller.c:30:21: fatal error: asm/tsc.h: No such file or directory
compilation terminated.
Okay i think I need to move this bit into the intel code.
Takashi, I didnt see any X86 depends on SND_HDA_INTEL. I think we should add this now. Are you okay with that?
Better to have an explicit ifdef CONFIG_X86 around it. It's not only for x86.
Need it around the whole of the timestamp code as well then..
Yes. But why TSC is mandatory? There is no explanation in your patch.
Yes the HDA controller is not x86 specfic, but the hda-intel should be, right?
No, the driver depends on PCI, but not on CPU.
thanks,
Takashi
On Fri, Jul 15, 2016 at 07:17:14AM +0200, Takashi Iwai wrote:
On Fri, 15 Jul 2016 07:19:06 +0200, Vinod Koul wrote:
> sound/pci/hda/hda_controller.c:30:21: fatal error: asm/tsc.h: No such file or directory
compilation terminated.
Okay i think I need to move this bit into the intel code.
Takashi, I didnt see any X86 depends on SND_HDA_INTEL. I think we should add this now. Are you okay with that?
Better to have an explicit ifdef CONFIG_X86 around it. It's not only for x86.
Need it around the whole of the timestamp code as well then..
Yes. But why TSC is mandatory? There is no explanation in your patch.
HW reports ART values and we need to convert these to TSC.
The callflow is that the azx_get_crosststamp is called which invokes get_device_system_crosststamp() and calls azx_get_sync_time callback.
So dependency is around convert_art_to_tsc() which is x86 API.
Thanks
On Fri, 15 Jul 2016 07:39:10 +0200, Vinod Koul wrote:
On Fri, Jul 15, 2016 at 07:17:14AM +0200, Takashi Iwai wrote:
On Fri, 15 Jul 2016 07:19:06 +0200, Vinod Koul wrote:
>> sound/pci/hda/hda_controller.c:30:21: fatal error: asm/tsc.h: No such file or directory compilation terminated.
Okay i think I need to move this bit into the intel code.
Takashi, I didnt see any X86 depends on SND_HDA_INTEL. I think we should add this now. Are you okay with that?
Better to have an explicit ifdef CONFIG_X86 around it. It's not only for x86.
Need it around the whole of the timestamp code as well then..
Yes. But why TSC is mandatory? There is no explanation in your patch.
HW reports ART values and we need to convert these to TSC.
The callflow is that the azx_get_crosststamp is called which invokes get_device_system_crosststamp() and calls azx_get_sync_time callback.
So dependency is around convert_art_to_tsc() which is x86 API.
How is defined in the spec? I wonder it because HD-audio spec itself is usually CPU-neutral.
Takashi
On Fri, Jul 15, 2016 at 07:39:17AM +0200, Takashi Iwai wrote:
So dependency is around convert_art_to_tsc() which is x86 API.
How is defined in the spec? I wonder it because HD-audio spec itself is usually CPU-neutral.
You are right. HDA spec is not x86 specfic. HDA counter report the value of ART counter for a time snapshot.
The problem is we do not get TSC value from HDA controller :(
So we need to use asm code for conversion..
Thanks
On Fri, 15 Jul 2016 07:50:25 +0200, Vinod Koul wrote:
On Fri, Jul 15, 2016 at 07:39:17AM +0200, Takashi Iwai wrote:
So dependency is around convert_art_to_tsc() which is x86 API.
How is defined in the spec? I wonder it because HD-audio spec itself is usually CPU-neutral.
You are right. HDA spec is not x86 specfic. HDA counter report the value of ART counter for a time snapshot.
The problem is we do not get TSC value from HDA controller :(
So we need to use asm code for conversion..
OK, then let's cover the relevant code with ifdef CONFIG_X86 as a temporary workaround until we get a more universal solution.
Takashi
participants (2)
-
Takashi Iwai -
Vinod Koul