[PATCH -next 1/2] ASoC: SOF: imx8ulp: change es8326_regmap_config to static
sof_imx8ulp_ops is only used in imx8ulp.c now, change it to static.
Signed-off-by: Yang Yingliang yangyingliang@huawei.com --- sound/soc/sof/imx/imx8ulp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sof/imx/imx8ulp.c b/sound/soc/sof/imx/imx8ulp.c index 02b496165acc..afab7feab5fb 100644 --- a/sound/soc/sof/imx/imx8ulp.c +++ b/sound/soc/sof/imx/imx8ulp.c @@ -413,7 +413,7 @@ static int imx8ulp_dsp_set_power_state(struct snd_sof_dev *sdev, }
/* i.MX8 ops */ -struct snd_sof_dsp_ops sof_imx8ulp_ops = { +static struct snd_sof_dsp_ops sof_imx8ulp_ops = { /* probe and remove */ .probe = imx8ulp_probe, .remove = imx8ulp_remove,
After using 'res_node' returned by of_parse_phandle(), of_node_put() need be called to decrease the refcount.
Fixes: fb5319af6ad8 ("ASoC: SOF: imx: Add i.MX8ULP HW support") Signed-off-by: Yang Yingliang yangyingliang@huawei.com --- sound/soc/sof/imx/imx8ulp.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/soc/sof/imx/imx8ulp.c b/sound/soc/sof/imx/imx8ulp.c index afab7feab5fb..4a562c9856e9 100644 --- a/sound/soc/sof/imx/imx8ulp.c +++ b/sound/soc/sof/imx/imx8ulp.c @@ -234,6 +234,7 @@ static int imx8ulp_probe(struct snd_sof_dev *sdev) }
ret = of_address_to_resource(res_node, 0, &res); + of_node_put(res_node); if (ret) { dev_err(&pdev->dev, "failed to get reserved region address\n"); goto exit_pdev_unregister;
On Wed, 24 Aug 2022 09:32:33 +0800, Yang Yingliang wrote:
sof_imx8ulp_ops is only used in imx8ulp.c now, change it to static.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/2] ASoC: SOF: imx8ulp: change es8326_regmap_config to static (no commit info) [2/2] ASoC: SOF: imx8ulp: add missing of_node_put() in imx8ulp_probe() commit: adc641f1dbce48914445efb79f302380ff10df10
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (2)
-
Mark Brown -
Yang Yingliang