[alsa-devel] [PATCH] ASoC: rockchip: Select DMA_PL330 by RK3399 audio
Without the appropriate DMA controller selected, the RK3399 audio drivers compile but fail immediately. Accordingly, selecting the RK3399 audio without the corresponding PL330 controller is an invalid configuration. Prevent errors (otherwise forcing the driver to unload at runtime) by an appropriate `select` directive in the Kconfig.
Signed-off-by: Alyssa Rosenzweig alyssa@rosenzweig.io Cc: Heiko Stuebner heiko@sntech.de Cc: Liam Girdwood lgirdwood@gmail.com Cc: Mark Brown broonie@kernel.org Cc: Jaroslav Kysela perex@perex.cz Cc: Takashi Iwai tiwai@suse.com --- sound/soc/rockchip/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig index 957046ac6c8c..fa3cab461a60 100644 --- a/sound/soc/rockchip/Kconfig +++ b/sound/soc/rockchip/Kconfig @@ -73,6 +73,7 @@ config SND_SOC_RK3399_GRU_SOUND select SND_SOC_RT5514_SPI select SND_SOC_HDMI_CODEC select SND_SOC_DMIC + select PL330_DMA help Say Y or M here if you want to add support multiple codecs for SoC audio on Rockchip RK3399 GRU boards.
On Sun, Apr 14, 2019 at 02:02:12PM -0700, Alyssa Rosenzweig wrote:
Without the appropriate DMA controller selected, the RK3399 audio drivers compile but fail immediately. Accordingly, selecting the RK3399 audio without the corresponding PL330 controller is an invalid configuration. Prevent errors (otherwise forcing the driver to unload at runtime) by an appropriate `select` directive in the Kconfig.
This breaks the build as it enables CONFIG_PL330 but that depends on AMBA which isn't selected so we end up with:
ld: drivers/dma/pl330.o: in function `pl330_driver_init': pl330.c:(.init.text+0x8): undefined reference to `amba_driver_register' ld: drivers/dma/pl330.o: in function `pl330_driver_exit': pl330.c:(.exit.text+0x8): undefined reference to `amba_driver_unregister' make: *** [Makefile:1029: vmlinux] Error 1
in my test configs.
participants (2)
-
Alyssa Rosenzweig
-
Mark Brown