Re: [alsa-devel] [PATCH 3/8] mfd: arizona: Add support for WM8998 and WM1814
22 Apr
2015
22 Apr
'15
1:08 p.m.
On Tue, Apr 21, 2015 at 01:33:51PM +0100, Richard Fitzgerald wrote:
- switch (arizona->type) {
- case WM8998:
- case WM1814:
/* Some bits are shifted on WM8998,* rearrange to match the standard bit layout*/val[0] = ((val[0] & 0x60e0) >> 1) |((val[0] & 0x1e00) >> 2) |(val[0] & 0x000f);break;
Are you sure this approach is going to scale (and avoid confusion)?
27 Apr
27 Apr
2:40 p.m.
New subject: [alsa-devel] [PATCH 3/8] mfd: arizona: Add support for WM8998 and WM1814
On Wed, Apr 22, 2015 at 12:08:08PM +0100, Mark Brown wrote:
On Tue, Apr 21, 2015 at 01:33:51PM +0100, Richard Fitzgerald wrote:
- switch (arizona->type) {
- case WM8998:
- case WM1814:
/* Some bits are shifted on WM8998,* rearrange to match the standard bit layout*/val[0] = ((val[0] & 0x60e0) >> 1) |((val[0] & 0x1e00) >> 2) |(val[0] & 0x000f);break;Are you sure this approach is going to scale (and avoid confusion)?
It's a total one-off for the WM8998/WM1814, no other codecs have this shifted-bit-position problem. This shouldn't happen for any future codecs, so I don't feel like it's worth over-complicating it.
3434
Age (days ago)
3439
Last active (days ago)
1 comments
2 participants
participants (2)
-
Mark Brown -
Richard Fitzgerald