[alsa-devel] [PATCH] Add default config for tegra-alc5632 (as found on paz00)
This makes paz00 (aka Toshiba ac100, a popular arm-based netbook) use dmix/dsnoop by default since it doesn't support hw mixing.
Signed-off-by: Paul Fertser fercerpav@gmail.com --- Hi,
I haven't seen any other ASoC configs here so probably i'm missing something obvious. My reasoning is that when a person uses a regular notebook with HDA he gets DMix by default so it should be the case for this less common netbook too.
Rate is set to 44100 because it's unlikely a person will listen to Hi-Fi music and hence it avoids resampling for the most common usecase. Feel free to drop if that's inappropriate, the device works fine with 48000 too.
src/conf/cards/Makefile.am | 1 + src/conf/cards/tegra-alc5632.conf | 23 +++++++++++++++++++++++ 2 files changed, 24 insertions(+), 0 deletions(-) create mode 100644 src/conf/cards/tegra-alc5632.conf
diff --git a/src/conf/cards/Makefile.am b/src/conf/cards/Makefile.am index b7190e7..efed590 100644 --- a/src/conf/cards/Makefile.am +++ b/src/conf/cards/Makefile.am @@ -44,6 +44,7 @@ cfg_files = aliases.conf \ RME9652.conf \ SI7018.conf \ SB-XFi.conf \ + tegra-alc5632.conf \ TRID4DWAVENX.conf \ USB-Audio.conf \ YMF744.conf \ diff --git a/src/conf/cards/tegra-alc5632.conf b/src/conf/cards/tegra-alc5632.conf new file mode 100644 index 0000000..371fe2a --- /dev/null +++ b/src/conf/cards/tegra-alc5632.conf @@ -0,0 +1,23 @@ +# default with dmix/dsnoop +tegra-alc5632.pcm.default { + @args [ CARD ] + @args.CARD { + type string + } + type asym + playback.pcm { + type plug + slave.pcm { + @func concat + strings [ "dmix:CARD=" $CARD ",RATE=44100" ] + } + } + capture.pcm { + type plug + slave.pcm { + @func concat + strings [ "dsnoop:CARD=" $CARD ",RATE=44100" ] + } + } +} +
On 02/06/2012 12:51 PM, Paul Fertser wrote:
This makes paz00 (aka Toshiba ac100, a popular arm-based netbook) use dmix/dsnoop by default since it doesn't support hw mixing.
This patch appears to match on card name being "tegra-alc5632", but the device tree code that just got checked in will name the card "Compal PAZ00" I believe. (and I believe this driver only supports DT not board files) Am I missing something?
On Tue, Feb 7, 2012 at 07:52, Stephen Warren swarren@nvidia.com wrote:
On 02/06/2012 12:51 PM, Paul Fertser wrote:
This makes paz00 (aka Toshiba ac100, a popular arm-based netbook) use dmix/dsnoop by default since it doesn't support hw mixing.
This patch appears to match on card name being "tegra-alc5632", but the device tree code that just got checked in will name the card "Compal PAZ00" I believe. (and I believe this driver only supports DT not board files) Am I missing something?
Stephen, Mark, I want to raise our old question: "How do we need to call this card ? Do we need to call it tegra-alc5632, as was in pre-DT era ? Or do we need to call it "Compal PAZ00" as we introduced in DT patches ?".
The both names are applicable because "Compal PAZ00" is the name of notebook (hardware board) and tegra-alc5632 is the name of chips were used.
-- nvpublic _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
On Tue, Feb 07, 2012 at 08:57:59AM +0200, Leon Romanovsky wrote:
I want to raise our old question: "How do we need to call this card ? Do we need to call it tegra-alc5632, as was in pre-DT era ? Or do we need to call it "Compal PAZ00" as we introduced in DT patches ?".
The both names are applicable because "Compal PAZ00" is the name of notebook (hardware board) and tegra-alc5632 is the name of chips were used.
I really don't care.
On Tue, Feb 07, 2012 at 08:57:59AM +0200, Leon Romanovsky wrote:
On Tue, Feb 7, 2012 at 07:52, Stephen Warren swarren@nvidia.com wrote:
On 02/06/2012 12:51 PM, Paul Fertser wrote:
This makes paz00 (aka Toshiba ac100, a popular arm-based netbook) use dmix/dsnoop by default since it doesn't support hw mixing.
This patch appears to match on card name being "tegra-alc5632", but the device tree code that just got checked in will name the card "Compal PAZ00" I believe. (and I believe this driver only supports DT not board files) Am I missing something?
Stephen, Mark, I want to raise our old question: "How do we need to call this card ? Do we need to call it tegra-alc5632, as was in pre-DT era ? Or do we need to call it "Compal PAZ00" as we introduced in DT patches ?".
The both names are applicable because "Compal PAZ00" is the name of notebook (hardware board) and tegra-alc5632 is the name of chips were used.
Since alsa-lib config file describes how to best deal with the combination of chips rather than a particular notebook name (especially given same device can have different names from different vendors and at the same time some vendors are ill-minded enough to call different devices with the same name) it would seem more logical to stick to the chips' names.
Mark, do you have some idea how to solve the issue at hand (having dmix on this netbook by default) better? Is quantity of maximum simultaneous playback/record PCM streams already queryable by the userspace? Somehow it happened that adding per-device config file was ok during all these years, is there a better way now?
On Tue, Feb 07, 2012 at 04:54:04PM +0400, Paul Fertser wrote:
Since alsa-lib config file describes how to best deal with the combination of chips rather than a particular notebook name (especially given same device can have different names from different vendors and at the same time some vendors are ill-minded enough to call different devices with the same name) it would seem more logical to stick to the chips' names.
That needn't follow - especially as you move into the higher end the devices get much more flexible and system concerns have a major impact on the configuration so the board in use becomes more and more important.
Mark, do you have some idea how to solve the issue at hand (having dmix on this netbook by default) better? Is quantity of maximum simultaneous playback/record PCM streams already queryable by the userspace? Somehow it happened that adding per-device config file was ok during all these years, is there a better way now?
For almost all devices there's one stream supported in each direction, if we were assuming any default that'd be it.
Hi,
On Tue, Feb 07, 2012 at 01:13:39PM +0000, Mark Brown wrote:
On Tue, Feb 07, 2012 at 04:54:04PM +0400, Paul Fertser wrote:
Mark, do you have some idea how to solve the issue at hand (having dmix on this netbook by default) better? Is quantity of maximum simultaneous playback/record PCM streams already queryable by the userspace? Somehow it happened that adding per-device config file was ok during all these years, is there a better way now?
For almost all devices there's one stream supported in each direction, if we were assuming any default that'd be it.
Takashi, can you please provide some feedback on this thread?
At Fri, 24 Feb 2012 12:43:47 +0400, Paul Fertser wrote:
Hi,
On Tue, Feb 07, 2012 at 01:13:39PM +0000, Mark Brown wrote:
On Tue, Feb 07, 2012 at 04:54:04PM +0400, Paul Fertser wrote:
Mark, do you have some idea how to solve the issue at hand (having dmix on this netbook by default) better? Is quantity of maximum simultaneous playback/record PCM streams already queryable by the userspace? Somehow it happened that adding per-device config file was ok during all these years, is there a better way now?
For almost all devices there's one stream supported in each direction, if we were assuming any default that'd be it.
Takashi, can you please provide some feedback on this thread?
The reason dmix is implemented in a white-list way in alsa-lib is that dmix isn't always working well. The support was limited on some architectures, and could be buggy when the buffer transfer isn't standard.
So, unless the situation doesn't change drastically, I don't think it's wise to change the policy for now. In your case, just apply tegra-alc5632, and define an alias of Compal PAZ00. This would be just a safer option.
Of course, if there are more hundreds of different drivers come up soon now with different card->driver name strings, and all of them must be set up with dmix, then we can reconsider.
thanks,
Takashi
On Tue, Feb 07, 2012 at 12:51:38AM +0400, Paul Fertser wrote:
I haven't seen any other ASoC configs here so probably i'm missing something obvious. My reasoning is that when a person uses a regular notebook with HDA he gets DMix by default so it should be the case for this less common netbook too.
It seems depressing that we'd need to go through and add this for every single card...
participants (5)
-
Leon Romanovsky -
Mark Brown -
Paul Fertser -
Stephen Warren -
Takashi Iwai