[alsa-devel] [PATCH] topology: fix output file unlinking
Unlinking is unecessary as the old file will be overwritten with the new as intended.
Signed-off-by: Liam Girdwood liam.r.girdwood@linux.intel.com --- src/topology/parser.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/src/topology/parser.c b/src/topology/parser.c index ed25bb8..5544517 100644 --- a/src/topology/parser.c +++ b/src/topology/parser.c @@ -266,9 +266,6 @@ int snd_tplg_build_file(snd_tplg_t *tplg, const char *infile, snd_config_t *cfg = NULL; int err = 0;
- /* delete any old output files */ - unlink(outfile); - tplg->out_fd = open(outfile, O_RDWR | O_CREAT, S_IRWXU | S_IRWXG | S_IRWXO); if (tplg->out_fd < 0) {
File was incorrectly world rwx.
Signed-off-by: Liam Girdwood liam.r.girdwood@linux.intel.com --- src/topology/parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/topology/parser.c b/src/topology/parser.c index 5544517..993f70d 100644 --- a/src/topology/parser.c +++ b/src/topology/parser.c @@ -267,7 +267,7 @@ int snd_tplg_build_file(snd_tplg_t *tplg, const char *infile, int err = 0;
tplg->out_fd = - open(outfile, O_RDWR | O_CREAT, S_IRWXU | S_IRWXG | S_IRWXO); + open(outfile, O_RDWR | O_CREAT, S_IRUSR | S_IWUSR); if (tplg->out_fd < 0) { SNDERR("error: failed to open %s err %d\n", outfile, -errno);
On Tue, 11 Aug 2015 15:25:59 +0200, Liam Girdwood wrote:
File was incorrectly world rwx.
Signed-off-by: Liam Girdwood liam.r.girdwood@linux.intel.com
Because of the problems I reported in the previous mail, I applied only the first patch (renaming OBJECT_TYPE_*) in v2 series, so far.
So, it's better to fold these two fixes into the last patch. Then submit v3 after fixing other reported issues.
thanks,
Takashi
src/topology/parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/topology/parser.c b/src/topology/parser.c index 5544517..993f70d 100644 --- a/src/topology/parser.c +++ b/src/topology/parser.c @@ -267,7 +267,7 @@ int snd_tplg_build_file(snd_tplg_t *tplg, const char *infile, int err = 0;
tplg->out_fd =
open(outfile, O_RDWR | O_CREAT, S_IRWXU | S_IRWXG | S_IRWXO);
open(outfile, O_RDWR | O_CREAT, S_IRUSR | S_IWUSR);-- 2.1.4
participants (2)
-
Liam Girdwood -
Takashi Iwai