[alsa-devel] [PATCH 2.6.28] ALSA: Ensure PXA runtime data is initialised
The rest of the code relies on the runtime data being zero initialised so we need to use kzalloc() to allocate it.
Reported-by: Oliver Ford ipaqlinux@oliford.co.uk Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com --- sound/arm/pxa2xx-pcm-lib.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/arm/pxa2xx-pcm-lib.c b/sound/arm/pxa2xx-pcm-lib.c index 1c93eb7..75a0d74 100644 --- a/sound/arm/pxa2xx-pcm-lib.c +++ b/sound/arm/pxa2xx-pcm-lib.c @@ -194,7 +194,7 @@ int __pxa2xx_pcm_open(struct snd_pcm_substream *substream) goto out;
ret = -ENOMEM; - rtd = kmalloc(sizeof(*rtd), GFP_KERNEL); + rtd = kzalloc(sizeof(*rtd), GFP_KERNEL); if (!rtd) goto out; rtd->dma_desc_array =
At Wed, 22 Oct 2008 13:27:49 +0100, Mark Brown wrote:
The rest of the code relies on the runtime data being zero initialised so we need to use kzalloc() to allocate it.
Reported-by: Oliver Ford ipaqlinux@oliford.co.uk Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com
Applied now. Will put it to the next pull request.
Thanks,
Takashi
sound/arm/pxa2xx-pcm-lib.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/arm/pxa2xx-pcm-lib.c b/sound/arm/pxa2xx-pcm-lib.c index 1c93eb7..75a0d74 100644 --- a/sound/arm/pxa2xx-pcm-lib.c +++ b/sound/arm/pxa2xx-pcm-lib.c @@ -194,7 +194,7 @@ int __pxa2xx_pcm_open(struct snd_pcm_substream *substream) goto out;
ret = -ENOMEM;
- rtd = kmalloc(sizeof(*rtd), GFP_KERNEL);
- rtd = kzalloc(sizeof(*rtd), GFP_KERNEL); if (!rtd) goto out; rtd->dma_desc_array =
-- 1.5.6.5
participants (2)
-
Mark Brown
-
Takashi Iwai