[alsa-devel] [PATCH] ALSA: hda - fix broken automute/autoswitch for Realtek
The recent addition of volume-knob widget in the auto-parser broke automute/autoswitch for some Realtek devices.
Signed-off-by: David Henningsson david.henningsson@canonical.com --- sound/pci/hda/patch_realtek.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 01179d5..7e65168 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -686,7 +686,7 @@ static void alc_sku_unsol_event(struct hda_codec *codec, unsigned int res) else res >>= 26; action = snd_hda_jack_get_action(codec, res); - if (res == ALC_DCVOL_EVENT) { + if (action == ALC_DCVOL_EVENT) { /* Execute the dc-vol event here as it requires the NID * but we don't pass NID to alc_exec_unsol_event(). * Once when we convert all static quirks to the auto-parser,
At Mon, 5 Mar 2012 11:38:46 +0100, David Henningsson wrote:
The recent addition of volume-knob widget in the auto-parser broke automute/autoswitch for some Realtek devices.
Signed-off-by: David Henningsson david.henningsson@canonical.com
Applied now. Thanks for spotting out.
Takashi
sound/pci/hda/patch_realtek.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 01179d5..7e65168 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -686,7 +686,7 @@ static void alc_sku_unsol_event(struct hda_codec *codec, unsigned int res) else res >>= 26; action = snd_hda_jack_get_action(codec, res);
- if (res == ALC_DCVOL_EVENT) {
- if (action == ALC_DCVOL_EVENT) { /* Execute the dc-vol event here as it requires the NID
- but we don't pass NID to alc_exec_unsol_event().
- Once when we convert all static quirks to the auto-parser,
-- 1.7.9
participants (2)
-
David Henningsson -
Takashi Iwai