Re: [alsa-devel] commit b1ef29725865 (ACPI _REV=2) causes sound regression on Dell XPS 13 [Was: Discussion around quirking the _REV behavior for the XPS 13 (2015) until 4.2]
On 05/12/2015 12:21 PM, Matthew Garrett wrote:
On Tue, May 12, 2015 at 9:18 AM, Mark Brown broonie@kernel.org wrote:
You need PulseAudio 6.0 but otherwise yes, it works for me.
Since there's no way to get this working without using new userspace, we're basically stuck with having to support _REV 5. And since we're supposed to support old userspace basically forever, this isn't going to be something that we can just remove in a few months. But since the hardware is intended to be used in I2S mode, we don't want this quirk to be there forever. So we're basically left with adding CONFIG_ACPI_WORKAROUND_BROKEN_DELLS which enables the quirk, default it to Y and then let distributions set it to N when they've got sufficiently new userspace. Unless someone has a better plan?
Just to be clear, from the Dell side only the XPS 13 9343 has this _REV behavior.
What's wrong with a DMI quirk until I2S is mature on the kernel side and userspace is new enough in distros? Is it too early in boot for DMI quirks? That would enforce that no other machines can use _REV value of 5 to detect Linux without breaking the 9343.
On Tue, May 12, 2015 at 12:29:48PM -0500, Mario Limonciello wrote:
On 05/12/2015 12:21 PM, Matthew Garrett wrote:
to be there forever. So we're basically left with adding CONFIG_ACPI_WORKAROUND_BROKEN_DELLS which enables the quirk, default it to Y and then let distributions set it to N when they've got sufficiently new userspace. Unless someone has a better plan?
Just to be clear, from the Dell side only the XPS 13 9343 has this _REV behavior.
What's wrong with a DMI quirk until I2S is mature on the kernel side and userspace is new enough in distros? Is it too early in boot for DMI quirks?
If we're waiting for distros to have new enough userspace we're looking at waiting several years at least, especially when you start looking at distros like Debian (which two of the users in this thread are, though I'm not on stable).
That would enforce that no other machines can use _REV value of 5 to detect Linux without breaking the 9343.
What Matthew suggested was making the quirk a compile time option.
participants (2)
-
Mario Limonciello -
Mark Brown