[alsa-devel] [PATCH] ASoC: Fix off-by-one bug in register cache size configuration
This is a simple off-by-one bug, the size of the register cache is incorrectly set to the maximum register index. Fix it by adding one.
Signed-off-by: Dimitris Papastamos dp@opensource.wolfsonmicro.com --- sound/soc/codecs/wm8962.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c index 58ba2d3..30984dd 100644 --- a/sound/soc/codecs/wm8962.c +++ b/sound/soc/codecs/wm8962.c @@ -1780,7 +1780,7 @@ static struct snd_soc_codec_driver soc_codec_dev_wm8962 = { .remove = wm8962_remove, .resume = wm8962_resume, .set_bias_level = wm8962_set_bias_level, - .reg_cache_size = WM8962_MAX_REGISTER, + .reg_cache_size = WM8962_MAX_REGISTER + 1, .reg_word_size = sizeof(u16), .reg_cache_default = wm8962_reg, .volatile_register = wm8962_volatile_register,
On Fri, 2010-09-10 at 18:24 +0100, Dimitris Papastamos wrote:
This is a simple off-by-one bug, the size of the register cache is incorrectly set to the maximum register index. Fix it by adding one.
Signed-off-by: Dimitris Papastamos dp@opensource.wolfsonmicro.com
Acked-by: Liam Girdwood lrg@slimlogic.co.uk
On Fri, Sep 10, 2010 at 06:24:08PM +0100, Dimitris Papastamos wrote:
This is a simple off-by-one bug, the size of the register cache is incorrectly set to the maximum register index. Fix it by adding one.
Signed-off-by: Dimitris Papastamos dp@opensource.wolfsonmicro.com
Applied, thanks.
participants (3)
-
Dimitris Papastamos
-
Liam Girdwood
-
Mark Brown