equalizer cfg in max98088 driver
Hi Mark, All, Just a question. Can you explain me the proper way to configure eq1 and eq2 of max98089 using sound/soc/codecs/max98088.c driver? Could be a valid solution fetching eq1, eq2 bands params from dts?
Let me know. Thanks in advance Tommaso
On Tue, Jul 05, 2022 at 09:55:00AM +0200, Tommaso Merciai wrote:
Just a question. Can you explain me the proper way to configure eq1 and eq2 of max98089 using sound/soc/codecs/max98088.c driver? Could be a valid solution fetching eq1, eq2 bands params from dts?
There's plenty of examples of equalisers in the code already. I don't know how this specific device works but generally these are either exposed as a series of volume like sliders or as binary controls. This doesn't restrict people to settings from the firmware, making development of new configuraitons much easier.
Hi Mark,
On Tue, Jul 05, 2022 at 12:18:06PM +0100, Mark Brown wrote:
On Tue, Jul 05, 2022 at 09:55:00AM +0200, Tommaso Merciai wrote:
Just a question. Can you explain me the proper way to configure eq1 and eq2 of max98089 using sound/soc/codecs/max98088.c driver? Could be a valid solution fetching eq1, eq2 bands params from dts?
There's plenty of examples of equalisers in the code already. I don't know how this specific device works but generally these are either exposed as a series of volume like sliders or as binary controls. This doesn't restrict people to settings from the firmware, making development of new configuraitons much easier.
Thanks for your reply. I meant somethings like this:
max98089: codec@10 { #sound-dai-cells = <0>; compatible = "maxim,max98089", "maxim,max98088"; reg = <0x10>; clocks = <&clk IMX8MM_CLK_SAI3_ROOT>; clock-names = "mclk";
/* eq1 cfg params */ eq1-cfg-dt-en; eq1-band1 = /bits/ 16 <0x2000 0xC001 0x4000 0x005D 0x0000>; eq1-band2 = /bits/ 16 <0x2C30 0xC01F 0x3DAA 0x03EC 0x111E>; eq1-band3 = /bits/ 16 <0x0C41 0xC0BE 0x29AA 0x09B5 0x3094>; eq1-band4 = /bits/ 16 <0x6671 0xC655 0x3036 0x1BC0 0x2A16>; eq1-band5 = /bits/ 16 <0x538D 0xD64E 0x23BD 0x308D 0x3517>; };
Regards, Tommaso
On Tue, Jul 05, 2022 at 06:29:56PM +0200, Tommaso Merciai wrote:
On Tue, Jul 05, 2022 at 12:18:06PM +0100, Mark Brown wrote:
There's plenty of examples of equalisers in the code already. I don't know how this specific device works but generally these are either exposed as a series of volume like sliders or as binary controls. This doesn't restrict people to settings from the firmware, making development of new configuraitons much easier.
Thanks for your reply. I meant somethings like this:
I understood what you meant, like I say this should be a runtime control.
participants (2)
-
Mark Brown -
Tommaso Merciai