[alsa-devel] [PATCH 0/2] Fix coding style issues in AK4458 DAC
Modify SPDX license comment style and sort headers alphabetically.
Cosmin-Gabriel Samoila (2): ASoC: ak4458: Modify SPDX license format ASoC: ak4458: Sort headers alphabetically
sound/soc/codecs/ak4458.c | 23 +++++++++++------------ sound/soc/codecs/ak4458.h | 2 +- 2 files changed, 12 insertions(+), 13 deletions(-)
Modify SPDX comment style to match the rules. Since the original code had a GPL-2.0 license and SPDX is compatible with GPL-2.0+, we also modified the MODULE_LICENSE.
Signed-off-by: Cosmin-Gabriel Samoila cosmin.samoila@nxp.com --- sound/soc/codecs/ak4458.c | 13 ++++++------- sound/soc/codecs/ak4458.h | 2 +- 2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c index d2815ac..8a49dd2 100644 --- a/sound/soc/codecs/ak4458.c +++ b/sound/soc/codecs/ak4458.c @@ -1,10 +1,9 @@ // SPDX-License-Identifier: GPL-2.0 -/* - * Audio driver for AK4458 DAC - * - * Copyright (C) 2016 Asahi Kasei Microdevices Corporation - * Copyright 2018 NXP - */ +// +// Audio driver for AK4458 DAC +// +// Copyright (C) 2016 Asahi Kasei Microdevices Corporation +// Copyright 2018 NXP
#include <linux/module.h> #include <linux/delay.h> @@ -655,4 +654,4 @@ module_i2c_driver(ak4458_i2c_driver); MODULE_AUTHOR("Junichi Wakasugi wakasugi.jb@om.asahi-kasei.co.jp"); MODULE_AUTHOR("Mihai Serban mihai.serban@nxp.com"); MODULE_DESCRIPTION("ASoC AK4458 DAC driver"); -MODULE_LICENSE("GPL"); +MODULE_LICENSE("GPL v2"); diff --git a/sound/soc/codecs/ak4458.h b/sound/soc/codecs/ak4458.h index 16d9d22..f906215 100644 --- a/sound/soc/codecs/ak4458.h +++ b/sound/soc/codecs/ak4458.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0 +/* SPDX-License-Identifier: GPL-2.0 */ /* * Audio driver for AK4458 *
The patch
ASoC: ak4458: Modify SPDX license format
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From 05aa6165cfdb796916197da6b8ef93b22a62e3a9 Mon Sep 17 00:00:00 2001
From: Cosmin-Gabriel Samoila cosmin.samoila@nxp.com Date: Tue, 20 Feb 2018 10:56:07 +0200 Subject: [PATCH] ASoC: ak4458: Modify SPDX license format
Modify SPDX comment style to match the rules. Since the original code had a GPL-2.0 license and SPDX is compatible with GPL-2.0+, we also modified the MODULE_LICENSE.
Signed-off-by: Cosmin-Gabriel Samoila cosmin.samoila@nxp.com Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/codecs/ak4458.c | 13 ++++++------- sound/soc/codecs/ak4458.h | 2 +- 2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c index d2815ac9cffa..8a49dd24e6b7 100644 --- a/sound/soc/codecs/ak4458.c +++ b/sound/soc/codecs/ak4458.c @@ -1,10 +1,9 @@ // SPDX-License-Identifier: GPL-2.0 -/* - * Audio driver for AK4458 DAC - * - * Copyright (C) 2016 Asahi Kasei Microdevices Corporation - * Copyright 2018 NXP - */ +// +// Audio driver for AK4458 DAC +// +// Copyright (C) 2016 Asahi Kasei Microdevices Corporation +// Copyright 2018 NXP
#include <linux/module.h> #include <linux/delay.h> @@ -655,4 +654,4 @@ module_i2c_driver(ak4458_i2c_driver); MODULE_AUTHOR("Junichi Wakasugi wakasugi.jb@om.asahi-kasei.co.jp"); MODULE_AUTHOR("Mihai Serban mihai.serban@nxp.com"); MODULE_DESCRIPTION("ASoC AK4458 DAC driver"); -MODULE_LICENSE("GPL"); +MODULE_LICENSE("GPL v2"); diff --git a/sound/soc/codecs/ak4458.h b/sound/soc/codecs/ak4458.h index 16d9d22a413a..f906215f7e4e 100644 --- a/sound/soc/codecs/ak4458.h +++ b/sound/soc/codecs/ak4458.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0 +/* SPDX-License-Identifier: GPL-2.0 */ /* * Audio driver for AK4458 *
Keep headers sorted alphabetically.
Signed-off-by: Cosmin-Gabriel Samoila cosmin.samoila@nxp.com --- sound/soc/codecs/ak4458.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c index 8a49dd2..31ec0ba 100644 --- a/sound/soc/codecs/ak4458.c +++ b/sound/soc/codecs/ak4458.c @@ -5,19 +5,19 @@ // Copyright (C) 2016 Asahi Kasei Microdevices Corporation // Copyright 2018 NXP
-#include <linux/module.h> #include <linux/delay.h> -#include <linux/slab.h> #include <linux/gpio/consumer.h> +#include <linux/i2c.h> +#include <linux/module.h> #include <linux/of_device.h> #include <linux/of_gpio.h> #include <linux/pm_runtime.h> -#include <linux/i2c.h> +#include <linux/slab.h> +#include <sound/initval.h> +#include <sound/pcm_params.h> #include <sound/soc.h> #include <sound/soc-dapm.h> -#include <sound/initval.h> #include <sound/tlv.h> -#include <sound/pcm_params.h>
#include "ak4458.h"
The patch
ASoC: ak4458: Sort headers alphabetically
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From de03af56602a3b57bfef958045a4d43ad50db46a Mon Sep 17 00:00:00 2001
From: Cosmin-Gabriel Samoila cosmin.samoila@nxp.com Date: Tue, 20 Feb 2018 10:56:08 +0200 Subject: [PATCH] ASoC: ak4458: Sort headers alphabetically
Keep headers sorted alphabetically.
Signed-off-by: Cosmin-Gabriel Samoila cosmin.samoila@nxp.com Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/codecs/ak4458.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c index 8a49dd24e6b7..31ec0ba2e639 100644 --- a/sound/soc/codecs/ak4458.c +++ b/sound/soc/codecs/ak4458.c @@ -5,19 +5,19 @@ // Copyright (C) 2016 Asahi Kasei Microdevices Corporation // Copyright 2018 NXP
-#include <linux/module.h> #include <linux/delay.h> -#include <linux/slab.h> #include <linux/gpio/consumer.h> +#include <linux/i2c.h> +#include <linux/module.h> #include <linux/of_device.h> #include <linux/of_gpio.h> #include <linux/pm_runtime.h> -#include <linux/i2c.h> +#include <linux/slab.h> +#include <sound/initval.h> +#include <sound/pcm_params.h> #include <sound/soc.h> #include <sound/soc-dapm.h> -#include <sound/initval.h> #include <sound/tlv.h> -#include <sound/pcm_params.h>
#include "ak4458.h"
participants (2)
-
Cosmin-Gabriel Samoila -
Mark Brown