[alsa-devel] [PATCH 09/12] ASoC: qcom: Remove unnecessary function call
First of all,the address of pdev->dev is assigned to card->dev,then the function platform_set_drvdata copies the value the variable card to pdev->dev.driver_data, but when calling snd_soc_register_card,the function dev_set_drvdata(card->dev, card) will also do the same copy operation,so i think that the former copy operation can be removed.
Signed-off-by: Peng Donglin dolinux.peng@gmail.com --- sound/soc/qcom/storm.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/qcom/storm.c b/sound/soc/qcom/storm.c index c5207af..a9fa972 100644 --- a/sound/soc/qcom/storm.c +++ b/sound/soc/qcom/storm.c @@ -99,7 +99,6 @@ static int storm_platform_probe(struct platform_device *pdev) return -ENOMEM;
card->dev = &pdev->dev; - platform_set_drvdata(pdev, card);
ret = snd_soc_of_parse_card_name(card, "qcom,model"); if (ret) {
On Sun, Aug 20, 2017 at 01:44:58PM +0800, Peng Donglin wrote:
First of all,the address of pdev->dev is assigned to card->dev,then the function platform_set_drvdata copies the value the variable card to pdev->dev.driver_data, but when calling snd_soc_register_card,the function dev_set_drvdata(card->dev, card) will also do the same copy operation,so i think that the former copy operation can be removed.
Signed-off-by: Peng Donglin dolinux.peng@gmail.com
Acked-by: Banajit Goswami bgoswami@codeaurora.org
sound/soc/qcom/storm.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/qcom/storm.c b/sound/soc/qcom/storm.c index c5207af..a9fa972 100644 --- a/sound/soc/qcom/storm.c +++ b/sound/soc/qcom/storm.c @@ -99,7 +99,6 @@ static int storm_platform_probe(struct platform_device *pdev) return -ENOMEM;
card->dev = &pdev->dev;
platform_set_drvdata(pdev, card);
ret = snd_soc_of_parse_card_name(card, "qcom,model"); if (ret) {
-- 1.9.1
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
participants (2)
-
Banajit Goswami -
Peng Donglin