[alsa-devel] [RESEND][PATCH 1/4] pxa2xx-i2s: Proper initialization
Reset FIFO logic and registers, and make sure REC and RPL functions along with FIFO service are disabled at probe.
Signed-off-by: Karl Beldan karl.beldan@mobile-devices.fr --- sound/soc/pxa/pxa2xx-i2s.c | 13 +++++++++++++ 1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/sound/soc/pxa/pxa2xx-i2s.c b/sound/soc/pxa/pxa2xx-i2s.c index 2f4b6e4..450fca6 100644 --- a/sound/soc/pxa/pxa2xx-i2s.c +++ b/sound/soc/pxa/pxa2xx-i2s.c @@ -346,6 +346,19 @@ static int pxa2xx_i2s_probe(struct platform_device *dev) if (ret != 0) clk_put(clk_i2s);
+ /* + * PXA Developer's Manual: + * If SACR0[ENB] is toggled in the middle of a normal operation, + * the SACR0[RST] bit must also be set and cleared to reset all + * I2S controller registers. + */ + SACR0 = SACR0_RST; + SACR0 = 0; + /* Make sure RPL and REC are disabled */ + SACR1 = SACR1_DRPL | SACR1_DREC; + /* Along with FIFO servicing */ + SAIMR &= ~(SAIMR_RFS | SAIMR_TFS); + return ret; }
On Mon, May 11, 2009 at 11:49:41PM +0200, Karl Beldan wrote:
Reset FIFO logic and registers, and make sure REC and RPL functions along with FIFO service are disabled at probe.
Signed-off-by: Karl Beldan karl.beldan@mobile-devices.fr
Applied, thanks.
participants (2)
-
Karl Beldan
-
Mark Brown