[PATCH v1] ALSA:ac97: Remove redundant driver match function
![](https://secure.gravatar.com/avatar/38ff1ad75b17939b69e8a13a257f62b2.jpg?s=120&d=mm&r=g)
If there is no driver match function, the driver core assumes that each candidate pair (driver, device) matches, see driver_match_device()
Drop the bus's match function that always returned 1 and so implements the same behaviour as when there is no match function.
Signed-off-by: Lizhe sensor1010@163.com --- sound/ac97_bus.c | 11 ----------- 1 file changed, 11 deletions(-)
diff --git a/sound/ac97_bus.c b/sound/ac97_bus.c index b4685c53ff11..c7aee8c42c55 100644 --- a/sound/ac97_bus.c +++ b/sound/ac97_bus.c @@ -75,19 +75,8 @@ int snd_ac97_reset(struct snd_ac97 *ac97, bool try_warm, unsigned int id, } EXPORT_SYMBOL_GPL(snd_ac97_reset);
-/* - * Let drivers decide whether they want to support given codec from their - * probe method. Drivers have direct access to the struct snd_ac97 - * structure and may decide based on the id field amongst other things. - */ -static int ac97_bus_match(struct device *dev, struct device_driver *drv) -{ - return 1; -} - struct bus_type ac97_bus_type = { .name = "ac97", - .match = ac97_bus_match, };
static int __init ac97_bus_init(void)
![](https://secure.gravatar.com/avatar/5b19e9d0e834ea10ef75803718ad564b.jpg?s=120&d=mm&r=g)
On Sun, 19 Mar 2023 05:47:33 +0100, Lizhe wrote:
If there is no driver match function, the driver core assumes that each candidate pair (driver, device) matches, see driver_match_device()
Drop the bus's match function that always returned 1 and so implements the same behaviour as when there is no match function.
Signed-off-by: Lizhe sensor1010@163.com
Is Lizeh your real full name? (i.e. your name is "Li Zhe" ?) I'm asking because the Signed-off-by line is a legal requirement.
thanks,
Takashi
![](https://secure.gravatar.com/avatar/38ff1ad75b17939b69e8a13a257f62b2.jpg?s=120&d=mm&r=g)
HI : my name is li Zhe, I am Chinese
At 2023-03-19 16:16:15, "Takashi Iwai" tiwai@suse.de wrote:
On Sun, 19 Mar 2023 05:47:33 +0100, Lizhe wrote:
If there is no driver match function, the driver core assumes that each candidate pair (driver, device) matches, see driver_match_device()
Drop the bus's match function that always returned 1 and so implements the same behaviour as when there is no match function.
Signed-off-by: Lizhe sensor1010@163.com
Is Lizeh your real full name? (i.e. your name is "Li Zhe" ?) I'm asking because the Signed-off-by line is a legal requirement.
thanks,
Takashi
![](https://secure.gravatar.com/avatar/5b19e9d0e834ea10ef75803718ad564b.jpg?s=120&d=mm&r=g)
On Sun, 19 Mar 2023 11:47:51 +0100, lizhe wrote:
HI : my name is li Zhe, I am Chinese
OK, then applied the patch now.
thanks,
Takashi
At 2023-03-19 16:16:15, "Takashi Iwai" tiwai@suse.de wrote:
On Sun, 19 Mar 2023 05:47:33 +0100, Lizhe wrote:
If there is no driver match function, the driver core assumes that each candidate pair (driver, device) matches, see driver_match_device()
Drop the bus's match function that always returned 1 and so implements the same behaviour as when there is no match function.
Signed-off-by: Lizhe sensor1010@163.com
Is Lizeh your real full name? (i.e. your name is "Li Zhe" ?) I'm asking because the Signed-off-by line is a legal requirement.
thanks,
Takashi
participants (2)
-
Lizhe
-
Takashi Iwai