On 09/06/2020 12:17, Jonathan Marek wrote:

On 6/9/20 1:26 AM, Vinod Koul wrote:

...

On 08-06-20, 16:43, Jonathan Marek wrote:

...

Add a compatible string for HW version v1.5.1 on sm8250 SoCs.

Please document this new compatible

Does it really need to be documented? The documentation already says the compatible should be "qcom,soundwire-v<MAJOR>.<MINOR>.<STEP>". It gives "qcom,soundwire-v1.5.0" as an example, which is not actually a supported compatible, so my understanding is we don't need to update the list of examples with every possible compatible.

checkpatch should have reported about this, and in future once we convert to yaml and list the compatible strings then dt_binding_check would fail too. So there is no harm in adding an additional compatible string for this new entry.

--srini