[PATCH v3 0/2] [PATCH v4 0/2] Add pinctrl support adsp bypass platforms
This patch set is to make clock voting optinal for adsp bypass sc7280 platforms.
Changes Since V3: -- Revert compatible type change in dt bindings. -- Update boolean flag description in dt bindings. -- Drop redundant clock optional flag initialization. -- Remove redundant if check. Changes Since V2: -- Remove redundant lpi pincontrol variant data structure and compatible entry. -- Add adsp bypass mode boolean param check. -- Remove compatible name in dt bindings. -- Update dt binding bypass mode boolean param. Changes Since V1: -- Update commit message.
Srinivasa Rao Mandadapu (2): dt-bindings: pinctrl: qcom: sc7280: Add boolean param for ADSP bypass platforms pinctrl: qcom: sc7280: Add clock optional check for ADSP bypass targets
.../devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml | 5 +++++ drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 2 ++ drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 1 - 3 files changed, 7 insertions(+), 1 deletion(-)
Add boolean param qcom,adsp-bypass-mode to support adsp bypassed sc7280 platforms. Which is required to make clock voting as optional for ADSP bypass platforms.
Signed-off-by: Srinivasa Rao Mandadapu quic_srivasam@quicinc.com --- .../devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml index d32ee32..33d1d37 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml @@ -19,6 +19,11 @@ properties: compatible: const: qcom,sc7280-lpass-lpi-pinctrl
+ qcom,adsp-bypass-mode: + description: + Tells ADSP is in bypass mode. + type: boolean + reg: minItems: 2 maxItems: 2
Quoting Srinivasa Rao Mandadapu (2022-06-10 21:22:36)
Add boolean param qcom,adsp-bypass-mode to support adsp bypassed sc7280 platforms. Which is required to make clock voting as optional for ADSP bypass platforms.
Signed-off-by: Srinivasa Rao Mandadapu quic_srivasam@quicinc.com
Reviewed-by: Stephen Boyd swboyd@chromium.org
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml index d32ee32..33d1d37 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml @@ -19,6 +19,11 @@ properties: compatible: const: qcom,sc7280-lpass-lpi-pinctrl
- qcom,adsp-bypass-mode:
- description:
Tells ADSP is in bypass mode.
Doubt "Tells" is required, but OK.
On Sat, 11 Jun 2022 09:52:36 +0530, Srinivasa Rao Mandadapu wrote:
Add boolean param qcom,adsp-bypass-mode to support adsp bypassed sc7280 platforms. Which is required to make clock voting as optional for ADSP bypass platforms.
Signed-off-by: Srinivasa Rao Mandadapu quic_srivasam@quicinc.com
.../devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Acked-by: Rob Herring robh@kernel.org
Update lpass lpi pin control driver, with clock optional check for ADSP disabled platforms. This check required for distingushing ADSP based platforms and ADSP bypass platforms. In case of ADSP enabled platforms, where audio is routed through ADSP macro and decodec GDSC Switches are triggered as clocks by pinctrl driver and ADSP firmware controls them. So It's mandatory to enable them in ADSP based solutions. In case of ADSP bypass platforms clock voting is optional as these macro and dcodec GDSC switches are maintained as power domains and operated from lpass clock drivers.
Signed-off-by: Srinivasa Rao Mandadapu quic_srivasam@quicinc.com Reviewed-by: Stephen Boyd swboyd@chromium.org --- drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 2 ++ drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 1 - 2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c index 74810ec..b3d4244 100644 --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c @@ -388,6 +388,8 @@ int lpi_pinctrl_probe(struct platform_device *pdev) pctrl->data = data; pctrl->dev = &pdev->dev;
+ data->is_clk_optional = of_property_read_bool(np, "qcom,adsp-bypass-mode"); + pctrl->clks[0].id = "core"; pctrl->clks[1].id = "audio";
diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c index 2add9a4..d615b6c5 100644 --- a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c +++ b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c @@ -141,7 +141,6 @@ static const struct lpi_pinctrl_variant_data sc7280_lpi_data = { .ngroups = ARRAY_SIZE(sc7280_groups), .functions = sc7280_functions, .nfunctions = ARRAY_SIZE(sc7280_functions), - .is_clk_optional = true, };
static const struct of_device_id lpi_pinctrl_of_match[] = {
On Sat, Jun 11, 2022 at 6:23 AM Srinivasa Rao Mandadapu quic_srivasam@quicinc.com wrote:
This patch set is to make clock voting optinal for adsp bypass sc7280 platforms.
Changes Since V3:
v4 looks really appetizing, just giving Bjorn some time to have a look before applying!
Yours, Linus Walleij
On Sat, Jun 11, 2022 at 6:23 AM Srinivasa Rao Mandadapu quic_srivasam@quicinc.com wrote:
This patch set is to make clock voting optinal for adsp bypass sc7280 platforms.
Changes Since V3:
This v4 patch set applied. Bjorn can yell if he has concerns and I'll pull it out again.
Yours, Linus Walleij
participants (4)
-
Linus Walleij -
Rob Herring -
Srinivasa Rao Mandadapu -
Stephen Boyd