[alsa-devel] [PATCH] ASoC: dmaengine: Use filter_data rather than dma_data for compat requests
From: Mark Brown broonie@linaro.org
When using the legacy filter function channel requests we currently pass the audio specific struct snd_dmaengine_dai_dma_data which isn't likely to be helpful for actual filtering. Since there's already a field in the structure called filter_data clearly intended for use here convert the driver to use that.
All existing users of plain filter functions have been converted to use an explict compat function to override this behaviour.
Signed-off-by: Mark Brown broonie@linaro.org --- sound/soc/soc-generic-dmaengine-pcm.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/sound/soc/soc-generic-dmaengine-pcm.c b/sound/soc/soc-generic-dmaengine-pcm.c index 99f9495..2eea2e0 100644 --- a/sound/soc/soc-generic-dmaengine-pcm.c +++ b/sound/soc/soc-generic-dmaengine-pcm.c @@ -168,6 +168,9 @@ static struct dma_chan *dmaengine_pcm_compat_request_channel( struct snd_pcm_substream *substream) { struct dmaengine_pcm *pcm = soc_platform_to_pcm(rtd->platform); + struct snd_dmaengine_dai_dma_data *dma_data; + + dma_data = snd_soc_dai_get_dma_data(rtd->cpu_dai, substream);
if ((pcm->flags & SND_DMAENGINE_PCM_FLAG_HALF_DUPLEX) && pcm->chan[0]) return pcm->chan[0]; @@ -176,7 +179,7 @@ static struct dma_chan *dmaengine_pcm_compat_request_channel( return pcm->config->compat_request_channel(rtd, substream);
return snd_dmaengine_pcm_request_channel(pcm->config->compat_filter_fn, - snd_soc_dai_get_dma_data(rtd->cpu_dai, substream)); + dma_data->filter_data); }
static int dmaengine_pcm_new(struct snd_soc_pcm_runtime *rtd)
On 10/19/2013 03:35 PM, Mark Brown wrote:
From: Mark Brown broonie@linaro.org
When using the legacy filter function channel requests we currently pass the audio specific struct snd_dmaengine_dai_dma_data which isn't likely to be helpful for actual filtering. Since there's already a field in the structure called filter_data clearly intended for use here convert the driver to use that.
All existing users of plain filter functions have been converted to use an explict compat function to override this behaviour.
I think this patch also needs to update sound/soc/fsl/imx-pcm-dma.c
On Sat, Oct 19, 2013 at 07:22:17PM +0200, Lars-Peter Clausen wrote:
I think this patch also needs to update sound/soc/fsl/imx-pcm-dma.c
Yes, I sent a patch for that I think? Or did I forget to post it?
participants (2)
-
Lars-Peter Clausen
-
Mark Brown