[alsa-devel] [PATCH 1/1] ALSA: atmel: Remove redundant platform_set_drvdata()
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL.
Signed-off-by: Sachin Kamat sachin.kamat@linaro.org --- sound/atmel/abdac.c | 2 -- sound/atmel/ac97c.c | 2 -- 2 files changed, 4 deletions(-)
diff --git a/sound/atmel/abdac.c b/sound/atmel/abdac.c index 071ce1b..872d59e 100644 --- a/sound/atmel/abdac.c +++ b/sound/atmel/abdac.c @@ -583,8 +583,6 @@ static int atmel_abdac_remove(struct platform_device *pdev) free_irq(dac->irq, dac); snd_card_free(card);
- platform_set_drvdata(pdev, NULL); - return 0; }
diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c index 6b7e2b5..ae63d22 100644 --- a/sound/atmel/ac97c.c +++ b/sound/atmel/ac97c.c @@ -1199,8 +1199,6 @@ static int atmel_ac97c_remove(struct platform_device *pdev) snd_card_set_dev(card, NULL); snd_card_free(card);
- platform_set_drvdata(pdev, NULL); - return 0; }
Around Fri 03 May 2013 12:26:28 +0530 or thereabout, Sachin Kamat wrote:
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL.
Signed-off-by: Sachin Kamat sachin.kamat@linaro.org
Thanks
Acked-by: Hans-Christian Egtvedt egtvedt@samfundet.no
sound/atmel/abdac.c | 2 -- sound/atmel/ac97c.c | 2 -- 2 files changed, 4 deletions(-)
<snipp diff>
On 03/05/2013 08:56, Sachin Kamat :
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL.
Signed-off-by: Sachin Kamat sachin.kamat@linaro.org
yes, as it is not needed anymore it may make sense to remove these calls...
Acked-by: Nicolas Ferre nicolas.ferre@atmel.com
sound/atmel/abdac.c | 2 -- sound/atmel/ac97c.c | 2 -- 2 files changed, 4 deletions(-)
diff --git a/sound/atmel/abdac.c b/sound/atmel/abdac.c index 071ce1b..872d59e 100644 --- a/sound/atmel/abdac.c +++ b/sound/atmel/abdac.c @@ -583,8 +583,6 @@ static int atmel_abdac_remove(struct platform_device *pdev) free_irq(dac->irq, dac); snd_card_free(card);
- platform_set_drvdata(pdev, NULL);
- return 0; }
diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c index 6b7e2b5..ae63d22 100644 --- a/sound/atmel/ac97c.c +++ b/sound/atmel/ac97c.c @@ -1199,8 +1199,6 @@ static int atmel_ac97c_remove(struct platform_device *pdev) snd_card_set_dev(card, NULL); snd_card_free(card);
- platform_set_drvdata(pdev, NULL);
- return 0; }
At Fri, 3 May 2013 12:26:28 +0530, Sachin Kamat wrote:
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL.
Signed-off-by: Sachin Kamat sachin.kamat@linaro.org
Thanks, applied now with acks by Hans-Christian and Nicolas.
Takashi
sound/atmel/abdac.c | 2 -- sound/atmel/ac97c.c | 2 -- 2 files changed, 4 deletions(-)
diff --git a/sound/atmel/abdac.c b/sound/atmel/abdac.c index 071ce1b..872d59e 100644 --- a/sound/atmel/abdac.c +++ b/sound/atmel/abdac.c @@ -583,8 +583,6 @@ static int atmel_abdac_remove(struct platform_device *pdev) free_irq(dac->irq, dac); snd_card_free(card);
- platform_set_drvdata(pdev, NULL);
- return 0;
}
diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c index 6b7e2b5..ae63d22 100644 --- a/sound/atmel/ac97c.c +++ b/sound/atmel/ac97c.c @@ -1199,8 +1199,6 @@ static int atmel_ac97c_remove(struct platform_device *pdev) snd_card_set_dev(card, NULL); snd_card_free(card);
- platform_set_drvdata(pdev, NULL);
- return 0;
}
-- 1.7.9.5
participants (4)
-
Hans-Christian Egtvedt -
Nicolas Ferre -
Sachin Kamat -
Takashi Iwai