On Wed, Jun 19, 2013 at 8:23 PM, Tomasz Figa tomasz.figa@gmail.com wrote:

On Monday 17 of June 2013 16:04:47 Linus Walleij wrote:

...

On Sun, Jun 16, 2013 at 10:54 PM, Tomasz Figa tomasz.figa@gmail.com

wrote:

...

...

+static AMBA_AHB_DEVICE(s3c64xx_dma1, "dma-pl080s.1", 0x0a141080,

•                   0x75100000, {IRQ_DMA1},
  

&s3c64xx_dma1_plat_data);

Ah, does this mean the device does not have any AMBA PrimeCell ID contents?

Hmm, not really. The ID here is what I copied from PrimeCell ID registers and the method of registration is taken from S5PV210. If I remove the override, it will read the same value from registers.

OK then don't override. Overriding is for hardware which is all zeroes in these registers.

...

Then use the ID 0x00053080 instead of 0x0a141080

0x53 is "S" for Samsung. Variant 0.

Well, that's kind of solution to make sure that it won't conflict with any future variant manufactured by ARM, I guess.

Yeah, but as stated, if the hardware has proper IDs (these are probably inspired by the PCI vendor/device/revision fields) then rely on those.

Yours, Linus Walleij