[alsa-devel] [PATCH 1/31] HDA patch_via.c: Remove IS_VT17xx_VENDORID macro
[ALSA] HDA VIA: Remove IS_VT17xx_VENDORID macro
Signed-off-by: Lydia Wang lydiawang@viatech.com.cn
Index: sound-2.6/sound/pci/hda/patch_via.c =================================================================== --- sound-2.6.orig/sound/pci/hda/patch_via.c 2009-09-29 18:01:12.000000000 +0800 +++ sound-2.6/sound/pci/hda/patch_via.c 2009-09-29 18:01:16.000000000 +0800 @@ -76,14 +76,6 @@ #define VT1702_HP_NID 0x17 #define VT1702_DIGOUT_NID 0x11
-#define IS_VT1708_VENDORID(x) ((x) >= 0x11061708 && (x) <= 0x1106170b) -#define IS_VT1709_10CH_VENDORID(x) ((x) >= 0x1106e710 && (x) <= 0x1106e713) -#define IS_VT1709_6CH_VENDORID(x) ((x) >= 0x1106e714 && (x) <= 0x1106e717) -#define IS_VT1708B_8CH_VENDORID(x) ((x) >= 0x1106e720 && (x) <= 0x1106e723) -#define IS_VT1708B_4CH_VENDORID(x) ((x) >= 0x1106e724 && (x) <= 0x1106e727) -#define IS_VT1708S_VENDORID(x) ((x) >= 0x11060397 && (x) <= 0x11067397) -#define IS_VT1702_VENDORID(x) ((x) >= 0x11060398 && (x) <= 0x11067398) - enum VIA_HDA_CODEC { UNKNOWN = -1, VT1708,
At Mon, 5 Oct 2009 21:28:00 +0800, Li Bo wrote:
[ALSA] HDA VIA: Remove IS_VT17xx_VENDORID macro
Signed-off-by: Lydia Wang lydiawang@viatech.com.cn
In general with your all patches, please give a bit more detailed changelog texs. For example, in this patch, it's not clear why they should be removed and what impact this change would have.
A single line text like below would help much to understand.
IS_VT17*_VENDORID macros are used nowhere, so clean them up.
thanks,
Takashi
Index: sound-2.6/sound/pci/hda/patch_via.c
--- sound-2.6.orig/sound/pci/hda/patch_via.c 2009-09-29 18:01:12.000000000 +0800 +++ sound-2.6/sound/pci/hda/patch_via.c 2009-09-29 18:01:16.000000000 +0800 @@ -76,14 +76,6 @@ #define VT1702_HP_NID 0x17 #define VT1702_DIGOUT_NID 0x11
-#define IS_VT1708_VENDORID(x) ((x) >= 0x11061708 && (x) <= 0x1106170b) -#define IS_VT1709_10CH_VENDORID(x) ((x) >= 0x1106e710 && (x) <= 0x1106e713) -#define IS_VT1709_6CH_VENDORID(x) ((x) >= 0x1106e714 && (x) <= 0x1106e717) -#define IS_VT1708B_8CH_VENDORID(x) ((x) >= 0x1106e720 && (x) <= 0x1106e723) -#define IS_VT1708B_4CH_VENDORID(x) ((x) >= 0x1106e724 && (x) <= 0x1106e727) -#define IS_VT1708S_VENDORID(x) ((x) >= 0x11060397 && (x) <= 0x11067397) -#define IS_VT1702_VENDORID(x) ((x) >= 0x11060398 && (x) <= 0x11067398)
enum VIA_HDA_CODEC { UNKNOWN = -1, VT1708,
[ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro
IS_VT17*_VENDORID macros are used nowhere, so clean them up.
Signed-off-by: Lydia Wang lydiawang@viatech.com.cn
--- sound/pci/hda/patch_via.c | 8 -------- 1 file changed, 8 deletions(-)
--- a/sound/pci/hda/patch_via.c +++ b/sound/pci/hda/patch_via.c @@ -76,14 +76,6 @@ #define VT1702_HP_NID 0x17 #define VT1702_DIGOUT_NID 0x11
-#define IS_VT1708_VENDORID(x) ((x) >= 0x11061708 && (x) <= 0x1106170b) -#define IS_VT1709_10CH_VENDORID(x) ((x) >= 0x1106e710 && (x) <= 0x1106e713) -#define IS_VT1709_6CH_VENDORID(x) ((x) >= 0x1106e714 && (x) <= 0x1106e717) -#define IS_VT1708B_8CH_VENDORID(x) ((x) >= 0x1106e720 && (x) <= 0x1106e723) -#define IS_VT1708B_4CH_VENDORID(x) ((x) >= 0x1106e724 && (x) <= 0x1106e727) -#define IS_VT1708S_VENDORID(x) ((x) >= 0x11060397 && (x) <= 0x11067397) -#define IS_VT1702_VENDORID(x) ((x) >= 0x11060398 && (x) <= 0x11067398) - enum VIA_HDA_CODEC { UNKNOWN = -1, VT1708,
At Thu, 8 Oct 2009 13:27:49 +0800, Li Bo wrote:
[ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro
IS_VT17*_VENDORID macros are used nowhere, so clean them up.
Signed-off-by: Lydia Wang lydiawang@viatech.com.cn
Li, could you add your sign-off, too, when you handle the patches? Otherwise I can't merge them.
thanks,
Takashi
At Thu, 08 Oct 2009 08:03:10 +0200, I wrote:
At Thu, 8 Oct 2009 13:27:49 +0800, Li Bo wrote:
[ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro
IS_VT17*_VENDORID macros are used nowhere, so clean them up.
Signed-off-by: Lydia Wang lydiawang@viatech.com.cn
Li, could you add your sign-off, too, when you handle the patches? Otherwise I can't merge them.
Also, please avoid sending a new patch as a reply to the old patch. This makes hard to follow, because many mailer handles the mails in a thread.
At best, post a new series of patches as a new thread.
thanks,
Takashi
On Thu, Oct 8, 2009 at 2:03 PM, Takashi Iwai tiwai@suse.de wrote:
At Thu, 8 Oct 2009 13:27:49 +0800, Li Bo wrote:
[ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro
IS_VT17*_VENDORID macros are used nowhere, so clean them up.
Signed-off-by: Lydia Wang lydiawang@viatech.com.cn
Li, could you add your sign-off, too, when you handle the patches? Otherwise I can't merge them.
thanks,
Takashi
Is that OK signed-off with LoganLi@viatech.com.cn with this gmail liboat@gamil.com? LoganLi@viatech.com.cn is my company's email. If not, I'll will resend them tomorrow when I go back to company.
At Thu, 8 Oct 2009 14:11:42 +0800, Li Bo wrote:
On Thu, Oct 8, 2009 at 2:03 PM, Takashi Iwai tiwai@suse.de wrote:
At Thu, 8 Oct 2009 13:27:49 +0800, Li Bo wrote:
[ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro
IS_VT17*_VENDORID macros are used nowhere, so clean them up.
Signed-off-by: Lydia Wang lydiawang@viatech.com.cn
Li, could you add your sign-off, too, when you handle the patches? Otherwise I can't merge them.
thanks,
Takashi
Is that OK signed-off with LoganLi@viatech.com.cn with this gmail liboat@gamil.com? LoganLi@viatech.com.cn is my company's email. If not, I'll will resend them tomorrow when I go back to company.
I don't care which address you use (and I don't know whether it matters your employer). It's fully your choice.
But, if the signed address is different from the mail sender, add a line "From: YOUR NAME your@mail" at the beginning of the patch explicitly.
thanks,
Takashi
On Thu, Oct 8, 2009 at 2:16 PM, Takashi Iwai tiwai@suse.de wrote:
At Thu, 8 Oct 2009 14:11:42 +0800, Li Bo wrote:
On Thu, Oct 8, 2009 at 2:03 PM, Takashi Iwai tiwai@suse.de wrote:
At Thu, 8 Oct 2009 13:27:49 +0800, Li Bo wrote:
[ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro
IS_VT17*_VENDORID macros are used nowhere, so clean them up.
Signed-off-by: Lydia Wang lydiawang@viatech.com.cn
Li, could you add your sign-off, too, when you handle the patches? Otherwise I can't merge them.
thanks,
Takashi
Is that OK signed-off with LoganLi@viatech.com.cn with this gmail liboat@gamil.com? LoganLi@viatech.com.cn is my company's email. If not, I'll will resend them tomorrow when I go back to company.
I don't care which address you use (and I don't know whether it matters your employer). It's fully your choice.
But, if the signed address is different from the mail sender, add a line "From: YOUR NAME your@mail" at the beginning of the patch explicitly.
thanks,
Takashi
I just randomly use my gmail. I will resend them tomorrow, thank you for teaching me:)
At Thu, 8 Oct 2009 14:22:07 +0800, Li Bo wrote:
On Thu, Oct 8, 2009 at 2:16 PM, Takashi Iwai tiwai@suse.de wrote:
At Thu, 8 Oct 2009 14:11:42 +0800, Li Bo wrote:
On Thu, Oct 8, 2009 at 2:03 PM, Takashi Iwai tiwai@suse.de wrote:
At Thu, 8 Oct 2009 13:27:49 +0800, Li Bo wrote:
[ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro
IS_VT17*_VENDORID macros are used nowhere, so clean them up.
Signed-off-by: Lydia Wang lydiawang@viatech.com.cn
Li, could you add your sign-off, too, when you handle the patches? Otherwise I can't merge them.
thanks,
Takashi
Is that OK signed-off with LoganLi@viatech.com.cn with this gmail liboat@gamil.com? LoganLi@viatech.com.cn is my company's email. If not, I'll will resend them tomorrow when I go back to company.
I don't care which address you use (and I don't know whether it matters your employer). It's fully your choice.
But, if the signed address is different from the mail sender, add a line "From: YOUR NAME your@mail" at the beginning of the patch explicitly.
thanks,
Takashi
I just randomly use my gmail. I will resend them tomorrow, thank you for teaching me:)
Well, I was unclear in the text above.
You can send patches with the sign-off of your company account even from your gmail account. Just add "From:" line with your company account in the patch text so that I can pick up the right address.
Takashi
On Thu, Oct 8, 2009 at 2:27 PM, Takashi Iwai tiwai@suse.de wrote:
At Thu, 8 Oct 2009 14:22:07 +0800, Li Bo wrote:
On Thu, Oct 8, 2009 at 2:16 PM, Takashi Iwai tiwai@suse.de wrote:
At Thu, 8 Oct 2009 14:11:42 +0800, Li Bo wrote:
On Thu, Oct 8, 2009 at 2:03 PM, Takashi Iwai tiwai@suse.de wrote:
At Thu, 8 Oct 2009 13:27:49 +0800, Li Bo wrote:
[ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro
IS_VT17*_VENDORID macros are used nowhere, so clean them up.
Signed-off-by: Lydia Wang lydiawang@viatech.com.cn
Li, could you add your sign-off, too, when you handle the patches? Otherwise I can't merge them.
thanks,
Takashi
Is that OK signed-off with LoganLi@viatech.com.cn with this gmail liboat@gamil.com? LoganLi@viatech.com.cn is my company's email. If not, I'll will resend them tomorrow when I go back to company.
I don't care which address you use (and I don't know whether it matters your employer). It's fully your choice.
But, if the signed address is different from the mail sender, add a line "From: YOUR NAME your@mail" at the beginning of the patch explicitly.
thanks,
Takashi
I just randomly use my gmail. I will resend them tomorrow, thank you for teaching me:)
Well, I was unclear in the text above.
You can send patches with the sign-off of your company account even from your gmail account. Just add "From:" line with your company account in the patch text so that I can pick up the right address.
Takashi
like this? [ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro
IS_VT17*_VENDORID macros are used nowhere, so clean them up.
Signed-off-by: Lydia Wang lydiawang@viatech.com.cn Signed-off-by: Logan Li loganli@viatech.com.cn From: Li Bo liboat@gmail.com
--- sound/pci/hda/patch_via.c | 8 -------- 1 file changed, 8 deletions(-)
--- a/sound/pci/hda/patch_via.c +++ b/sound/pci/hda/patch_via.c @@ -76,14 +76,6 @@ #define VT1702_HP_NID 0x17 #define VT1702_DIGOUT_NID 0x11
-#define IS_VT1708_VENDORID(x) ((x) >= 0x11061708 && (x) <= 0x1106170b) -#define IS_VT1709_10CH_VENDORID(x) ((x) >= 0x1106e710 && (x) <= 0x1106e713) -#define IS_VT1709_6CH_VENDORID(x) ((x) >= 0x1106e714 && (x) <= 0x1106e717) -#define IS_VT1708B_8CH_VENDORID(x) ((x) >= 0x1106e720 && (x) <= 0x1106e723) -#define IS_VT1708B_4CH_VENDORID(x) ((x) >= 0x1106e724 && (x) <= 0x1106e727) -#define IS_VT1708S_VENDORID(x) ((x) >= 0x11060397 && (x) <= 0x11067397) -#define IS_VT1702_VENDORID(x) ((x) >= 0x11060398 && (x) <= 0x11067398) - enum VIA_HDA_CODEC { UNKNOWN = -1, VT1708,
At Thu, 8 Oct 2009 15:28:17 +0800, Li Bo wrote:
On Thu, Oct 8, 2009 at 2:27 PM, Takashi Iwai tiwai@suse.de wrote:
At Thu, 8 Oct 2009 14:22:07 +0800, Li Bo wrote:
On Thu, Oct 8, 2009 at 2:16 PM, Takashi Iwai tiwai@suse.de wrote:
At Thu, 8 Oct 2009 14:11:42 +0800, Li Bo wrote:
On Thu, Oct 8, 2009 at 2:03 PM, Takashi Iwai tiwai@suse.de wrote:
At Thu, 8 Oct 2009 13:27:49 +0800, Li Bo wrote: > > [ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro > > IS_VT17*_VENDORID macros are used nowhere, so clean them up. > > Signed-off-by: Lydia Wang lydiawang@viatech.com.cn
Li, could you add your sign-off, too, when you handle the patches? Otherwise I can't merge them.
thanks,
Takashi
Is that OK signed-off with LoganLi@viatech.com.cn with this gmail liboat@gamil.com? LoganLi@viatech.com.cn is my company's email. If not, I'll will resend them tomorrow when I go back to company.
I don't care which address you use (and I don't know whether it matters your employer). It's fully your choice.
But, if the signed address is different from the mail sender, add a line "From: YOUR NAME your@mail" at the beginning of the patch explicitly.
thanks,
Takashi
I just randomly use my gmail. I will resend them tomorrow, thank you for teaching me:)
Well, I was unclear in the text above.
You can send patches with the sign-off of your company account even from your gmail account. Just add "From:" line with your company account in the patch text so that I can pick up the right address.
Takashi
like this? [ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro
IS_VT17*_VENDORID macros are used nowhere, so clean them up.
Signed-off-by: Lydia Wang lydiawang@viatech.com.cn Signed-off-by: Logan Li loganli@viatech.com.cn From: Li Bo liboat@gmail.com
No, add your sign-off address, i.e. "Logan Li loganli@viatech.com.cn" to From: line, and put it at the beginning of the patch.
But, now another question is who is the original author of the patch. Is it Lydia? Then the "From:" line should be of Lydia. In that way, we can clarify who is the original author.
If you changed something from the original patch, better to mention in the changelog text, too.
And, at best, add "Subject:" to each subject line, so that git-am can pick up properly. So, the patch head would look like:
From: Lydia Wang lydiawang@viatech.com.cn Subject: ALSA: HDA VIA: Fix blah blah
blah blah ...
Changed foo bar by Logan Li. blah blah ...
Signed-off-by: Lydia Wang lydiawang@viatech.com.cn Signed-off-by: Logan Li loganli@viatech.com.cn
thanks,
Takashi
On Thu, Oct 8, 2009 at 3:36 PM, Takashi Iwai tiwai@suse.de wrote:
At Thu, 8 Oct 2009 15:28:17 +0800, Li Bo wrote:
On Thu, Oct 8, 2009 at 2:27 PM, Takashi Iwai tiwai@suse.de wrote:
At Thu, 8 Oct 2009 14:22:07 +0800, Li Bo wrote:
On Thu, Oct 8, 2009 at 2:16 PM, Takashi Iwai tiwai@suse.de wrote:
At Thu, 8 Oct 2009 14:11:42 +0800, Li Bo wrote:
On Thu, Oct 8, 2009 at 2:03 PM, Takashi Iwai tiwai@suse.de wrote: > At Thu, 8 Oct 2009 13:27:49 +0800, > Li Bo wrote: >> >> [ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro >> >> IS_VT17*_VENDORID macros are used nowhere, so clean them up. >> >> Signed-off-by: Lydia Wang lydiawang@viatech.com.cn > > Li, could you add your sign-off, too, when you handle the patches? > Otherwise I can't merge them. > > > thanks, > > Takashi >
Is that OK signed-off with LoganLi@viatech.com.cn with this gmail liboat@gamil.com? LoganLi@viatech.com.cn is my company's email. If not, I'll will resend them tomorrow when I go back to company.
I don't care which address you use (and I don't know whether it matters your employer). It's fully your choice.
But, if the signed address is different from the mail sender, add a line "From: YOUR NAME your@mail" at the beginning of the patch explicitly.
thanks,
Takashi
I just randomly use my gmail. I will resend them tomorrow, thank you for teaching me:)
Well, I was unclear in the text above.
You can send patches with the sign-off of your company account even from your gmail account. Just add "From:" line with your company account in the patch text so that I can pick up the right address.
Takashi
like this? [ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro
IS_VT17*_VENDORID macros are used nowhere, so clean them up.
Signed-off-by: Lydia Wang lydiawang@viatech.com.cn Signed-off-by: Logan Li loganli@viatech.com.cn From: Li Bo liboat@gmail.com
No, add your sign-off address, i.e. "Logan Li loganli@viatech.com.cn" to From: line, and put it at the beginning of the patch.
But, now another question is who is the original author of the patch. Is it Lydia? Then the "From:" line should be of Lydia. In that way, we can clarify who is the original author.
If you changed something from the original patch, better to mention in the changelog text, too.
And, at best, add "Subject:" to each subject line, so that git-am can pick up properly. So, the patch head would look like:
From: Lydia Wang lydiawang@viatech.com.cn Subject: ALSA: HDA VIA: Fix blah blah
blah blah ...
Changed foo bar by Logan Li. blah blah ...
Signed-off-by: Lydia Wang lydiawang@viatech.com.cn Signed-off-by: Logan Li loganli@viatech.com.cn
thanks,
Takashi
Yes, Lydia is the original author. like this?
From: Lydia Wang lydiawang@viatech.com.cn Subject: ALSA: HDA VIA: Remove unused IS_VT17xx_VENDORID macro
IS_VT17*_VENDORID macros are used nowhere, so clean them up.
Signed-off-by: Lydia Wang lydiawang@viatech.com.cn Signed-off-by: Li Bo liboat@gmail.com.cn
--- sound/pci/hda/patch_via.c | 8 -------- 1 file changed, 8 deletions(-)
At Thu, 8 Oct 2009 15:56:51 +0800, Li Bo wrote:
On Thu, Oct 8, 2009 at 3:36 PM, Takashi Iwai tiwai@suse.de wrote:
At Thu, 8 Oct 2009 15:28:17 +0800, Li Bo wrote:
On Thu, Oct 8, 2009 at 2:27 PM, Takashi Iwai tiwai@suse.de wrote:
At Thu, 8 Oct 2009 14:22:07 +0800, Li Bo wrote:
On Thu, Oct 8, 2009 at 2:16 PM, Takashi Iwai tiwai@suse.de wrote:
At Thu, 8 Oct 2009 14:11:42 +0800, Li Bo wrote: > > On Thu, Oct 8, 2009 at 2:03 PM, Takashi Iwai tiwai@suse.de wrote: > > At Thu, 8 Oct 2009 13:27:49 +0800, > > Li Bo wrote: > >> > >> [ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro > >> > >> IS_VT17*_VENDORID macros are used nowhere, so clean them up. > >> > >> Signed-off-by: Lydia Wang lydiawang@viatech.com.cn > > > > Li, could you add your sign-off, too, when you handle the patches? > > Otherwise I can't merge them. > > > > > > thanks, > > > > Takashi > > > > Is that OK signed-off with LoganLi@viatech.com.cn with this gmail > liboat@gamil.com? LoganLi@viatech.com.cn is my company's email. > If not, I'll will resend them tomorrow when I go back to company.
I don't care which address you use (and I don't know whether it matters your employer). It's fully your choice.
But, if the signed address is different from the mail sender, add a line "From: YOUR NAME your@mail" at the beginning of the patch explicitly.
thanks,
Takashi
I just randomly use my gmail. I will resend them tomorrow, thank you for teaching me:)
Well, I was unclear in the text above.
You can send patches with the sign-off of your company account even from your gmail account. Just add "From:" line with your company account in the patch text so that I can pick up the right address.
Takashi
like this? [ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro
IS_VT17*_VENDORID macros are used nowhere, so clean them up.
Signed-off-by: Lydia Wang lydiawang@viatech.com.cn Signed-off-by: Logan Li loganli@viatech.com.cn From: Li Bo liboat@gmail.com
No, add your sign-off address, i.e. "Logan Li loganli@viatech.com.cn" to From: line, and put it at the beginning of the patch.
But, now another question is who is the original author of the patch. Is it Lydia? Then the "From:" line should be of Lydia. In that way, we can clarify who is the original author.
If you changed something from the original patch, better to mention in the changelog text, too.
And, at best, add "Subject:" to each subject line, so that git-am can pick up properly. So, the patch head would look like:
From: Lydia Wang lydiawang@viatech.com.cn Subject: ALSA: HDA VIA: Fix blah blah
blah blah ...
Changed foo bar by Logan Li. blah blah ...
Signed-off-by: Lydia Wang lydiawang@viatech.com.cn Signed-off-by: Logan Li loganli@viatech.com.cn
thanks,
Takashi
Yes, Lydia is the original author. like this?
From: Lydia Wang lydiawang@viatech.com.cn Subject: ALSA: HDA VIA: Remove unused IS_VT17xx_VENDORID macro
IS_VT17*_VENDORID macros are used nowhere, so clean them up.
Signed-off-by: Lydia Wang lydiawang@viatech.com.cn Signed-off-by: Li Bo liboat@gmail.com.cn
Yep. You can use your company address for your own sign-off here, too, if you prefer, even if you send from another address.
thanks,
Takashi
Thank you for your patience. I'll update today.
李波 Logan Li MCE-RD-Software-Audio/Video VIA Technologies, Inc. (Beijing)
-----邮件原件----- 发件人: Takashi Iwai [mailto:tiwai@suse.de] 发送时间: 2009年10月8日 16:09 收件人: Li Bo 抄送: alsa-devel@alsa-project.org; Harald Welte; Lydia Wang; Logan Li 主题: Re: [PATCH 1/31] HDA patch_via.c: Remove IS_VT17xx_VENDORID macro
At Thu, 8 Oct 2009 15:56:51 +0800, Li Bo wrote:
On Thu, Oct 8, 2009 at 3:36 PM, Takashi Iwai tiwai@suse.de wrote:
At Thu, 8 Oct 2009 15:28:17 +0800, Li Bo wrote:
On Thu, Oct 8, 2009 at 2:27 PM, Takashi Iwai tiwai@suse.de wrote:
At Thu, 8 Oct 2009 14:22:07 +0800, Li Bo wrote:
On Thu, Oct 8, 2009 at 2:16 PM, Takashi Iwai tiwai@suse.de wrote:
At Thu, 8 Oct 2009 14:11:42 +0800, Li Bo wrote: > > On Thu, Oct 8, 2009 at 2:03 PM, Takashi Iwai tiwai@suse.de wrote: > > At Thu, 8 Oct 2009 13:27:49 +0800, Li Bo wrote: > >> > >> [ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro > >> > >> IS_VT17*_VENDORID macros are used nowhere, so clean them up. > >> > >> Signed-off-by: Lydia Wang lydiawang@viatech.com.cn > > > > Li, could you add your sign-off, too, when you handle the patches? > > Otherwise I can't merge them. > > > > > > thanks, > > > > Takashi > > > > Is that OK signed-off with LoganLi@viatech.com.cn with this > gmail liboat@gamil.com? LoganLi@viatech.com.cn is my company's email. > If not, I'll will resend them tomorrow when I go back to company.
I don't care which address you use (and I don't know whether it matters your employer). It's fully your choice.
But, if the signed address is different from the mail sender, add a line "From: YOUR NAME your@mail" at the beginning of the patch explicitly.
thanks,
Takashi
I just randomly use my gmail. I will resend them tomorrow, thank you for teaching me:)
Well, I was unclear in the text above.
You can send patches with the sign-off of your company account even from your gmail account. Just add "From:" line with your company account in the patch text so that I can pick up the right address.
Takashi
like this? [ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro
IS_VT17*_VENDORID macros are used nowhere, so clean them up.
Signed-off-by: Lydia Wang lydiawang@viatech.com.cn Signed-off-by: Logan Li loganli@viatech.com.cn From: Li Bo liboat@gmail.com
No, add your sign-off address, i.e. "Logan Li loganli@viatech.com.cn" to From: line, and put it at the beginning of the patch.
But, now another question is who is the original author of the patch. Is it Lydia? Then the "From:" line should be of Lydia. In that way, we can clarify who is the original author.
If you changed something from the original patch, better to mention in the changelog text, too.
And, at best, add "Subject:" to each subject line, so that git-am can pick up properly. So, the patch head would look like:
From: Lydia Wang lydiawang@viatech.com.cn Subject: ALSA: HDA VIA: Fix blah blah
blah blah ...
Changed foo bar by Logan Li. blah blah ...
Signed-off-by: Lydia Wang lydiawang@viatech.com.cn Signed-off-by: Logan Li loganli@viatech.com.cn
thanks,
Takashi
Yes, Lydia is the original author. like this?
From: Lydia Wang lydiawang@viatech.com.cn Subject: ALSA: HDA VIA: Remove unused IS_VT17xx_VENDORID macro
IS_VT17*_VENDORID macros are used nowhere, so clean them up.
Signed-off-by: Lydia Wang lydiawang@viatech.com.cn Signed-off-by: Li Bo liboat@gmail.com.cn
Yep. You can use your company address for your own sign-off here, too, if you prefer, even if you send from another address.
thanks,
Takashi
participants (3)
-
Li Bo -
LoganLi＠viatech.com.cn -
Takashi Iwai