Hi Jaroslav,

I need to check with Intel chrome audio team for the name change. But chrome OS used 'alc-sense-combo' for early patch file. It also need to add this patch.

Oh! Sorry! I sent it with HTML mode. I need to resend again for TXT mode.

BR, Kailang

-----Original Message----- From: Jaroslav Kysela perex@perex.cz Sent: Thursday, March 7, 2019 4:03 PM To: Kailang kailang@realtek.com; Takashi Iwai (tiwai@suse.de) tiwai@suse.de Cc: (alsa-devel@alsa-project.org) alsa-devel@alsa-project.org Subject: Re: [alsa-devel] ChromeBook machine will lose MIC JD

Dne 07. 03. 19 v 8:56 Kailang napsal(a):

Hi Takashi,

Attach patch will solve the issue for Mic JD lose.

- {.id = ALC225_FIXUP_HEADSET_JACK, .name = "alc-sense-combo"}, + {.id = ALC295_FIXUP_CHROME_BOOK, .name = "alc-sense-combo"},

Define another name here like 'alc-chrome-book' and don't remove the previous model name 'alc-sense-combo'.

Jaroslav

-- Jaroslav Kysela perex@perex.cz Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

------Please consider the environment before printing this e-mail.

Hi Jaroslav,

I had modified the patch as you mentioned. But I don't know how to use git send-email.

BR, Kailang

-----Original Message----- From: Jaroslav Kysela perex@perex.cz Sent: Friday, March 8, 2019 3:49 AM To: Kailang kailang@realtek.com; Takashi Iwai (tiwai@suse.de) tiwai@suse.de Cc: (alsa-devel@alsa-project.org) alsa-devel@alsa-project.org Subject: Re: [alsa-devel] ChromeBook machine will lose MIC JD

Dne 07. 03. 19 v 9:11 Kailang napsal(a):

Hi Jaroslav,

I need to check with Intel chrome audio team for the name change. But chrome OS used 'alc-sense-combo' for early patch file.

But with your patch, the ALC225_FIXUP_HEADSET_JACK and ALC295_FIXUP_CHROME_BOOK do a different thing, so it's not a simple replacement. Your chrome book fixup is not universal, so it should be distinguished in my opinion.

Also, please, inline your patches or use ;git send-email' command to send your commit to this ML for a review.

Thanks, Jaroslav

It also need to add this patch.

Oh! Sorry! I sent it with HTML mode. I need to resend again for TXT mode.

BR, Kailang

-----Original Message----- From: Jaroslav Kysela perex@perex.cz Sent: Thursday, March 7, 2019 4:03 PM To: Kailang kailang@realtek.com; Takashi Iwai (tiwai@suse.de) tiwai@suse.de Cc: (alsa-devel@alsa-project.org) alsa-devel@alsa-project.org Subject: Re: [alsa-devel] ChromeBook machine will lose MIC JD

Dne 07. 03. 19 v 8:56 Kailang napsal(a):

...

Hi Takashi,

Attach patch will solve the issue for Mic JD lose.

• {.id = ALC225_FIXUP_HEADSET_JACK, .name = "alc-sense-combo"},

• {.id = ALC295_FIXUP_CHROME_BOOK, .name = "alc-sense-combo"},

Define another name here like 'alc-chrome-book' and don't remove the previous model name 'alc-sense-combo'.

				Jaroslav

-- Jaroslav Kysela perex@perex.cz Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

------Please consider the environment before printing this e-mail.

-- Jaroslav Kysela perex@perex.cz Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

Thanks. Takashi.

-----Original Message----- From: Takashi Iwai tiwai@suse.de Sent: Wednesday, March 13, 2019 6:51 PM To: Jaroslav Kysela perex@perex.cz Cc: Kailang kailang@realtek.com; (alsa-devel@alsa-project.org) alsa-devel@alsa-project.org Subject: Re: [alsa-devel] ChromeBook machine will lose MIC JD

On Thu, 07 Mar 2019 20:49:22 +0100, Jaroslav Kysela wrote:

Dne 07. 03. 19 v 9:11 Kailang napsal(a):

...

Hi Jaroslav,

I need to check with Intel chrome audio team for the name change. But chrome OS used 'alc-sense-combo' for early patch file.

But with your patch, the ALC225_FIXUP_HEADSET_JACK and ALC295_FIXUP_CHROME_BOOK do a different thing, so it's not a simple replacement. Your chrome book fixup is not universal, so it should be distinguished in my opinion.

Yeah, ideally this should be implemented in another model name.

But, in this particular case, the original quirk was provided specifically for Chromebook (despite of its generic model name "alc-sense-combo"), and since Chromebook is already using this string, it's better to keep the string as before. That is, the risk of breakage for other users of this model name is much lower than the burden of changes of the fixed string for Chrome, I suppose.

So I'm going to take the patch as is -- as an exception.

Also, please, inline your patches or use ;git send-email' command to send your commit to this ML for a review.

Right. But I thought it was some problem in Kailang's company network to use git-send-email. But some other people from Realtek seem capable to send patches in the git way, so it can be doable, as it seems.

thanks,

Takashi

			Thanks,
				Jaroslav

...

It also need to add this patch.

Oh! Sorry! I sent it with HTML mode. I need to resend again for TXT mode.

BR, Kailang

-----Original Message----- From: Jaroslav Kysela perex@perex.cz Sent: Thursday, March 7, 2019 4:03 PM To: Kailang kailang@realtek.com; Takashi Iwai (tiwai@suse.de) tiwai@suse.de Cc: (alsa-devel@alsa-project.org) alsa-devel@alsa-project.org Subject: Re: [alsa-devel] ChromeBook machine will lose MIC JD

Dne 07. 03. 19 v 8:56 Kailang napsal(a):

...

Hi Takashi,

Attach patch will solve the issue for Mic JD lose.

• {.id = ALC225_FIXUP_HEADSET_JACK, .name = "alc-sense-combo"},

• {.id = ALC295_FIXUP_CHROME_BOOK, .name = "alc-sense-combo"},

Define another name here like 'alc-chrome-book' and don't remove the previous model name 'alc-sense-combo'.

				Jaroslav

-- Jaroslav Kysela perex@perex.cz Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

------Please consider the environment before printing this e-mail.

-- Jaroslav Kysela perex@perex.cz Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

On Thu, 14 Mar 2019 08:43:52 +0100, Jaroslav Kysela wrote:

Dne 13. 03. 19 v 11:50 Takashi Iwai napsal(a):

...

On Thu, 07 Mar 2019 20:49:22 +0100, Jaroslav Kysela wrote:

...

Dne 07. 03. 19 v 9:11 Kailang napsal(a):

...

Hi Jaroslav,

I need to check with Intel chrome audio team for the name change. But chrome OS used 'alc-sense-combo' for early patch file.

But with your patch, the ALC225_FIXUP_HEADSET_JACK and ALC295_FIXUP_CHROME_BOOK do a different thing, so it's not a simple replacement. Your chrome book fixup is not universal, so it should be distinguished in my opinion.

Yeah, ideally this should be implemented in another model name.

But, in this particular case, the original quirk was provided specifically for Chromebook (despite of its generic model name "alc-sense-combo"), and since Chromebook is already using this string, it's better to keep the string as before. That is, the risk of breakage for other users of this model name is much lower than the burden of changes of the fixed string for Chrome, I suppose.\

So I'm going to take the patch as is -- as an exception.

It would be better to move the new code to alc_fixup_headset_jack() then, because ALC225_FIXUP_HEADSET_JACK is not reused and we don't have a model name for it now. I would create new fixup routines only when really necessary.

Makes sense. Care to send a cleanup patch on the top?

Thanks!

Takashi