[alsa-devel] [PATCH] ASoC: tegra: fix Tegra30 I2S capture parameter setup
From: Stephen Warren swarren@nvidia.com
The Tegra30 I2S driver was writing the AHUB interface parameters to the playback path register rather than the capture path register. This caused the capture parameters not to be configured at all, so if capturing using non-HW-default parameters (e.g. 16-bit stereo rather than 8-bit mono) the audio would be corrupted.
With this fixed, audio capture from an analog microphone works correctly on the Cardhu board.
Cc: stable@vger.kernel.org Signed-off-by: Stephen Warren swarren@nvidia.com --- sound/soc/tegra/tegra30_i2s.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/tegra/tegra30_i2s.c b/sound/soc/tegra/tegra30_i2s.c index d04146c..47565fd04 100644 --- a/sound/soc/tegra/tegra30_i2s.c +++ b/sound/soc/tegra/tegra30_i2s.c @@ -228,7 +228,7 @@ static int tegra30_i2s_hw_params(struct snd_pcm_substream *substream, reg = TEGRA30_I2S_CIF_RX_CTRL; } else { val |= TEGRA30_AUDIOCIF_CTRL_DIRECTION_TX; - reg = TEGRA30_I2S_CIF_RX_CTRL; + reg = TEGRA30_I2S_CIF_TX_CTRL; }
regmap_write(i2s->regmap, reg, val);
On Wed, Aug 14, 2013 at 02:24:16PM -0600, Stephen Warren wrote:
From: Stephen Warren swarren@nvidia.com
The Tegra30 I2S driver was writing the AHUB interface parameters to the playback path register rather than the capture path register. This caused the capture parameters not to be configured at all, so if capturing using non-HW-default parameters (e.g. 16-bit stereo rather than 8-bit mono) the audio would be corrupted.
Applied, thanks.
participants (2)
-
Mark Brown
-
Stephen Warren