Re: [alsa-devel] Tenor TE8802, USB : clics and crackles during music play
mick wrote:
I tried the patch but it does not help. Still crackles.
Do you get changing values, and any out-of-range values, when you execute this while it's playing?
(while sleep 0.123; do grep 'Momentary freq' /proc/asound/card*/stream0; done) | uniq
Regards, Clemens
Clemens,
I figured out what the problem is. When I said the quirk code gets called I made a mistake. It did not. What happens is this: You are setting udh01_fb_quirk in the sync endpoint but at the line where you query it you are asking the data endpoint. So the patch of the patch is:
- if (unlikely(ep->udh01_fb_quirk)) { + if (unlikely(sender->udh01_fb_quirk)) {
With this change everything works fine with my TEAC A-H01. The crackle is gone and grep for the momentary frequency shows no jumps anymore.
Regards, Mick
On 04/14/2014 12:44 PM, mick wrote:
I figured out what the problem is. When I said the quirk code gets called I made a mistake. It did not. What happens is this: You are setting udh01_fb_quirk in the sync endpoint but at the line where you query it you are asking the data endpoint. So the patch of the patch is:
- if (unlikely(ep->udh01_fb_quirk)) {
- if (unlikely(sender->udh01_fb_quirk)) {
With this change everything works fine with my TEAC A-H01. The crackle is gone and grep for the momentary frequency shows no jumps anymore.
Nice catch. Clemens, with the above correction of the patch, Andrea Messa reported success as well (had some private conversation on this).
When respinning the patch, you can add
Tested-by: Andrea Messa andr.messa@tiscali.it
Many thanks, everyone!
Daniel
participants (3)
-
Clemens Ladisch -
Daniel Mack -
mick