[alsa-devel] [PATCH v7 0/3] ARM: mxs: add recording support for saif
Changes since v6: * fix a typo suggested by Shawn * add tag from Marek Vasut
Changes since v5: Only one change is that: * remove the unneccesary parenthesis for [PATCH 1/3] suggested by Marek Vasut.
Changes since v4: * use new added master_id and master_mode in platform_data. The new changes depend on another patch: 0001-ASoC-mxs-saif-remove-function-in-platform_data.patch
Changes since v3: * remove unneeded locking according to Sascha. The patches are based on imx-features branch since commit: ca4e419c2.
Changes since v2: * separate clkmux code into another patch according to Uwe * add lock according to Wolfram * Other minus fixes suggested by Uwe and Wolfram. * remove Wolfram's fix saif clock setting patch which is in v2 series since Wolfram will reform the clock code and send it out himself. For test purpose, user still needs that patch. People can get it from v2 series. The patch is: [PATCH v2 3/3] arm: mxs: disable clock-gates when setting saif-clocks
The patches are based on imx-features branch since commit: f4f01e31835f.
Changes since v1: The main changes are move mach-specific code(clkmux in DIGCTL) from saif driver to mach-specific layer based on Wolfram's suggestion.
Note that the last patch is a RFC patch and sent out for testing since without that patch the saif may not work.
Dong Aisheng (3): ARM: mxs: add saif clkmux functions ARM: mx28evk: add platform data for saif ARM: mx28evk: set a initial clock rate for saif
arch/arm/mach-mxs/clock-mx28.c | 38 +++++++++++++++++++++++ arch/arm/mach-mxs/devices-mx28.h | 3 +- arch/arm/mach-mxs/devices/platform-mxs-saif.c | 5 ++- arch/arm/mach-mxs/include/mach/common.h | 1 + arch/arm/mach-mxs/include/mach/devices-common.h | 4 ++- arch/arm/mach-mxs/include/mach/digctl.h | 21 ++++++++++++ arch/arm/mach-mxs/mach-mx28evk.c | 18 +++++++++- 7 files changed, 84 insertions(+), 6 deletions(-) create mode 100644 arch/arm/mach-mxs/include/mach/digctl.h
On Tue, Nov 22, 2011 at 11:54:22PM +0800, Dong Aisheng wrote: [...]
Dong Aisheng (3): ARM: mxs: add saif clkmux functions ARM: mx28evk: add platform data for saif ARM: mx28evk: set a initial clock rate for saif
arch/arm/mach-mxs/clock-mx28.c | 38 +++++++++++++++++++++++ arch/arm/mach-mxs/devices-mx28.h | 3 +- arch/arm/mach-mxs/devices/platform-mxs-saif.c | 5 ++- arch/arm/mach-mxs/include/mach/common.h | 1 + arch/arm/mach-mxs/include/mach/devices-common.h | 4 ++- arch/arm/mach-mxs/include/mach/digctl.h | 21 ++++++++++++ arch/arm/mach-mxs/mach-mx28evk.c | 18 +++++++++- 7 files changed, 84 insertions(+), 6 deletions(-) create mode 100644 arch/arm/mach-mxs/include/mach/digctl.h
Applied, thanks.
During the testing, the saif driver's dependency on REGULATOR_FIXED_VOLTAGE was found. I guess it should be resolved in sound/soc/mxs/Kconfig rather than leaving it to users.
On Thu, Nov 24, 2011 at 03:36:05PM +0800, Shawn Guo wrote:
During the testing, the saif driver's dependency on REGULATOR_FIXED_VOLTAGE was found. I guess it should be resolved in sound/soc/mxs/Kconfig rather than leaving it to users.
Also SND_SOC_MXS_SGTL5000 should probably depends on I2C_MXS than I2C.
On Thu, Nov 24, 2011 at 03:46:20PM +0800, Shawn Guo wrote:
On Thu, Nov 24, 2011 at 03:36:05PM +0800, Shawn Guo wrote:
During the testing, the saif driver's dependency on REGULATOR_FIXED_VOLTAGE was found. I guess it should be resolved in sound/soc/mxs/Kconfig rather than leaving it to users.
Also SND_SOC_MXS_SGTL5000 should probably depends on I2C_MXS than I2C.
Hmm, I think it's common and accepted that an i2c device doesn't depend on an i2c bus driver. In this case it's quite probable that you want I2C_MXS, but technically you could also use I2C_GPIO.
Best regards Uwe
On Thu, Nov 24, 2011 at 03:46:20PM +0800, Shawn Guo wrote:
On Thu, Nov 24, 2011 at 03:36:05PM +0800, Shawn Guo wrote:
During the testing, the saif driver's dependency on REGULATOR_FIXED_VOLTAGE was found. I guess it should be resolved in sound/soc/mxs/Kconfig rather than leaving it to users.
Also SND_SOC_MXS_SGTL5000 should probably depends on I2C_MXS than I2C.
Please explain.
On Thu, Nov 24, 2011 at 08:49:38AM +0100, Wolfram Sang wrote:
On Thu, Nov 24, 2011 at 03:46:20PM +0800, Shawn Guo wrote:
On Thu, Nov 24, 2011 at 03:36:05PM +0800, Shawn Guo wrote:
During the testing, the saif driver's dependency on REGULATOR_FIXED_VOLTAGE was found. I guess it should be resolved in sound/soc/mxs/Kconfig rather than leaving it to users.
Also SND_SOC_MXS_SGTL5000 should probably depends on I2C_MXS than I2C.
Please explain.
Sorry. I meant 'select I2C_MXS'.
Also SND_SOC_MXS_SGTL5000 should probably depends on I2C_MXS than I2C.
Please explain.
Sorry. I meant 'select I2C_MXS'.
From kconfig-language.txt:
Note: select should be used with care. select will force a symbol to a value without visiting the dependencies. By abusing select you are able to select a symbol FOO even if FOO depends on BAR that is not set. In general use select only for non-visible symbols (no prompts anywhere) and for symbols with no dependencies. That will limit the usefulness but on the other hand avoid the illegal configurations all over.
So, NACK from me.
participants (4)
-
Dong Aisheng -
Shawn Guo -
Uwe Kleine-König -
Wolfram Sang