[alsa-devel] [PATCH] ASoC: omap-pcm: Correct dma mask
DMA_BIT_MASK of 64 is not valid dma address mask for OMAPs, it should be set to 32. The 64 was introduced by commit (in 2009): a152ff24b978 ASoC: OMAP: Make DMA 64 aligned
But the dma_mask and coherent_dma_mask can not be used to specify alignment.
Signed-off-by: Peter Ujfalusi peter.ujfalusi@ti.com --- sound/soc/omap/omap-pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c index 54d59e4f8f5f..d52a6d1ae55d 100644 --- a/sound/soc/omap/omap-pcm.c +++ b/sound/soc/omap/omap-pcm.c @@ -227,7 +227,7 @@ static int omap_pcm_new(struct snd_soc_pcm_runtime *rtd) struct snd_pcm *pcm = rtd->pcm; int ret;
- ret = dma_coerce_mask_and_coherent(card->dev, DMA_BIT_MASK(64)); + ret = dma_coerce_mask_and_coherent(card->dev, DMA_BIT_MASK(32)); if (ret) return ret;
Mark,
On 03/03/2015 04:08 PM, Mark Brown wrote:
On Tue, Mar 03, 2015 at 01:38:14PM +0200, Peter Ujfalusi wrote:
DMA_BIT_MASK of 64 is not valid dma address mask for OMAPs, it should be set to 32. The 64 was introduced by commit (in 2009): a152ff24b978 ASoC: OMAP: Make DMA 64 aligned
Applied, thanks.
Would it be possible to add this tags to the patch, I forgot it:
Reported-by: Grygorii Strashko Grygorii.Strashko@linaro.org
Thanks, Péter
On Tue, Mar 03, 2015 at 04:36:34PM +0200, Peter Ujfalusi wrote:
Would it be possible to add this tags to the patch, I forgot it:
Reported-by: Grygorii Strashko Grygorii.Strashko@linaro.org
Done.
participants (2)
-
Mark Brown -
Peter Ujfalusi