[alsa-devel] [PATCH] ALSA: ASoC: Remove const attribute from lm49453's snd_soc_dai_driver
Fixes the following build warning.
CC sound/soc/codecs/lm49453.o sound/soc/codecs/lm49453.c: In function ‘lm49453_i2c_probe’: sound/soc/codecs/lm49453.c:1511:24: warning: passing argument 3 of ‘snd_soc_register_codec’ discards qualifiers from pointer target type include/sound/soc.h:333:5: note: expected ‘struct snd_soc_dai_driver *’ but argument is of type ‘const struct snd_soc_dai_driver *’
Signed-off-by: Daniel Mack zonque@gmail.com --- sound/soc/codecs/lm49453.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/lm49453.c b/sound/soc/codecs/lm49453.c index 802b9f1..5bd1294 100644 --- a/sound/soc/codecs/lm49453.c +++ b/sound/soc/codecs/lm49453.c @@ -1358,7 +1358,7 @@ static struct snd_soc_dai_ops lm49453_lineout_dai_ops = { };
/* LM49453 dai structure. */ -static const struct snd_soc_dai_driver lm49453_dai[] = { +static struct snd_soc_dai_driver lm49453_dai[] = { { .name = "LM49453 Headset", .playback = {
On Wed, Jun 27, 2012 at 09:34:36AM +0200, Daniel Mack wrote:
Fixes the following build warning.
CC sound/soc/codecs/lm49453.o sound/soc/codecs/lm49453.c: In function ‘lm49453_i2c_probe’:
This has been fixed for about a month...
On 27.06.2012 12:17, Mark Brown wrote:
On Wed, Jun 27, 2012 at 09:34:36AM +0200, Daniel Mack wrote:
Fixes the following build warning.
CC sound/soc/codecs/lm49453.o sound/soc/codecs/lm49453.c: In function ‘lm49453_i2c_probe’:
This has been fixed for about a month...
Ah, ok, thanks. It's just not in Linus' tree yet, and I got the warning while building a 3.5-rc4.
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=sound/...
At Wed, 27 Jun 2012 11:17:51 +0100, Mark Brown wrote:
On Wed, Jun 27, 2012 at 09:34:36AM +0200, Daniel Mack wrote:
Fixes the following build warning.
CC sound/soc/codecs/lm49453.o sound/soc/codecs/lm49453.c: In function ‘lm49453_i2c_probe’:
This has been fixed for about a month...
Could you put it in the next pull request? It's not fixed in the upstream yet.
Takashi
On Wed, Jun 27, 2012 at 12:25:43PM +0200, Takashi Iwai wrote:
Could you put it in the next pull request? It's not fixed in the upstream yet.
It's fixed in -next, not in for-3.5. I guess I'll pick the change over at some point.
At Wed, 27 Jun 2012 12:11:21 +0100, Mark Brown wrote:
On Wed, Jun 27, 2012 at 12:25:43PM +0200, Takashi Iwai wrote:
Could you put it in the next pull request? It's not fixed in the upstream yet.
It's fixed in -next, not in for-3.5. I guess I'll pick the change over at some point.
Hm, OK.
Ideally, such a problem should have been fixed for 3.5 by just removing const, and add const again once after ASoC core is changed for 3.6. But I've been ignoring this warning since it's certainly no big issue.
Takashi
On Wed, Jun 27, 2012 at 01:39:52PM +0200, Takashi Iwai wrote:
Mark Brown wrote:
It's fixed in -next, not in for-3.5. I guess I'll pick the change over at some point.
Ideally, such a problem should have been fixed for 3.5 by just removing const, and add const again once after ASoC core is changed for 3.6. But I've been ignoring this warning since it's certainly no big issue.
The fix in -next is to remove the const, it's not simply a case of adding the const in the core as we currently fiddle with the ops structs to add default ops (which we shouldn't do).
participants (3)
-
Daniel Mack -
Mark Brown -
Takashi Iwai