[PATCH 1/1] [Patch v2] ALSA: HDA: Asus UM5302LA: Added quirks for cs35L41/10431A83 on i2c bus
Hi Takashi,
Proposed second revision of the patch that fixes the initialization of CSC3551 on the UM5302LA laptop. Patching the DSDT table is not required since ASUS did add _DSD entry. Nothing new introduced but reused work started by Stefan B.
Currently there is no official firmware available for 10431A83 on cirrus git unfortunately. For testing used 104317f3 (which is also seems on i2c bus):
$ cd /lib/firmware/cirrus/ && \ for fw in $(find ./ -name '*104317f3*'); do newfw=$(echo $fw | sed 's/104317f3/10431a83/g'); echo echo "$fw -> $newfw"; ln -s $f $newfw; done
With the patch applied to 6.6.0 and obviously symlinks to 104317F3 FW, speakers work and to my surprise they sound quite good and loud without distortion.
Probably confirmation from the cirrus team is needed on firmware.
Signed-off-by: Vitalii Torshyn vitaly.torshyn@gmail.com --- diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 58006c8bc..a28d078c9 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -7444,6 +7444,7 @@ enum { <----->ALC287_FIXUP_THINKPAD_I2S_SPK, <----->ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD, <----->ALC2XX_FIXUP_HEADSET_MIC, +<----->ALC294_FIXUP_CS35L41_I2C_2 }; . /* A special fixup for Lenovo C940 and Yoga Duet 7; @@ -9552,6 +9553,11 @@ static const struct hda_fixup alc269_fixups[] = { <-----><------>.type = HDA_FIXUP_FUNC, <-----><------>.v.func = alc_fixup_headset_mic, <----->}, +<----->[ALC294_FIXUP_CS35L41_I2C_2] = { +<-----><------>.type = HDA_FIXUP_FUNC, +<-----><------>.v.func = cs35l41_fixup_i2c_two, +<----->}, + }; . static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -9913,6 +9919,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { <----->SND_PCI_QUIRK(0x1043, 0x19e1, "ASUS UX581LV", ALC295_FIXUP_ASUS_MIC_NO_PRESENCE), <----->SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW), <----->SND_PCI_QUIRK(0x1043, 0x1a30, "ASUS X705UD", ALC256_FIXUP_ASUS_MIC), +<----->SND_PCI_QUIRK(0x1043, 0x1a83, "ASUS UM5302LA", ALC294_FIXUP_CS35L41_I2C_2), <----->SND_PCI_QUIRK(0x1043, 0x1a8f, "ASUS UX582ZS", ALC245_FIXUP_CS35L41_SPI_2), <----->SND_PCI_QUIRK(0x1043, 0x1b11, "ASUS UX431DA", ALC294_FIXUP_ASUS_COEF_1B), <----->SND_PCI_QUIRK(0x1043, 0x1b13, "Asus U41SV", ALC269_FIXUP_INV_DMIC),
On Thu, 09 Nov 2023 15:36:55 +0100, vitaly.torshyn@gmail.com wrote:
Hi Takashi,
Proposed second revision of the patch that fixes the initialization of CSC3551 on the UM5302LA laptop. Patching the DSDT table is not required since ASUS did add _DSD entry. Nothing new introduced but reused work started by Stefan B.
Currently there is no official firmware available for 10431A83 on cirrus git unfortunately. For testing used 104317f3 (which is also seems on i2c bus):
$ cd /lib/firmware/cirrus/ && \ for fw in $(find ./ -name '*104317f3*'); do newfw=$(echo $fw | sed 's/104317f3 /10431a83/g'); echo echo "$fw -> $newfw"; ln -s $f $newfw; done
With the patch applied to 6.6.0 and obviously symlinks to 104317F3 FW, speakers work and to my surprise they sound quite good and loud without distortion.
Probably confirmation from the cirrus team is needed on firmware.
Signed-off-by: Vitalii Torshyn vitaly.torshyn@gmail.com
Now I merged the patch, but at the next time, please try avoiding MIME patches. I had to edit and modify manually. At best, try to submit via git-send-email.
Also, please update the patch for the latest sound.git tree at the next time, too. There was a conflicting update and the manual adjustment was needed.
thanks,
Takashi
participants (1)
-
Takashi Iwai
-
vitaly.torshyn@gmail.com