Re: [alsa-devel] [PATCH 5/7] ASoC: constify snd_soc_ops structures
On Mon, 24 Oct 2016, Mark Brown wrote:
On Sat, Oct 15, 2016 at 04:55:49PM +0200, Julia Lawall wrote:
sound/soc/generic/simple-card.c | 2 +- sound/soc/generic/simple-scu-card.c | 2 +- sound/soc/intel/boards/bdw-rt5677.c | 2 +- sound/soc/intel/boards/bxt_da7219_max98357a.c | 4 ++-- sound/soc/intel/boards/bxt_rt298.c | 4 ++-- sound/soc/intel/boards/bytcr_rt5640.c | 4 ++-- sound/soc/intel/boards/bytcr_rt5651.c | 4 ++-- sound/soc/intel/boards/cht_bsw_max98090_ti.c | 4 ++-- sound/soc/intel/boards/cht_bsw_rt5645.c | 4 ++-- sound/soc/intel/boards/cht_bsw_rt5672.c | 4 ++-- sound/soc/intel/boards/haswell.c | 2 +- sound/soc/intel/boards/skl_nau88l25_max98357a.c | 6 +++--- sound/soc/intel/boards/skl_nau88l25_ssm4567.c | 6 +++--- sound/soc/intel/boards/skl_rt286.c | 4 ++-- sound/soc/kirkwood/armada-370-db.c | 2 +- sound/soc/mxs/mxs-sgtl5000.c | 2 +- 16 files changed, 28 insertions(+), 28 deletions(-)
You split out a few drivers as separate patches but not these ones - what's special about these ones?
If it's preferred, I could send them all one file at a time, or when the maintainers are very similar just send one patch to all the maintainers.
julia
On Tue, 2016-10-25 at 07:55 +0200, Julia Lawall wrote:
On Mon, 24 Oct 2016, Mark Brown wrote:
On Sat, Oct 15, 2016 at 04:55:49PM +0200, Julia Lawall wrote:
sound/soc/generic/simple-card.c | 2 +-
[...]
sound/soc/mxs/mxs-sgtl5000.c | 2 +- 16 files changed, 28 insertions(+), 28 deletions(-)
You split out a few drivers as separate patches but not these ones - what's special about these ones?
If it's preferred, I could send them all one file at a time, or when the maintainers are very similar just send one patch to all the maintainers.
Whatever works. There's no single style appropriate for the entire kernel.
On Tue, 25 Oct 2016, Joe Perches wrote:
On Tue, 2016-10-25 at 07:55 +0200, Julia Lawall wrote:
On Mon, 24 Oct 2016, Mark Brown wrote:
On Sat, Oct 15, 2016 at 04:55:49PM +0200, Julia Lawall wrote:
sound/soc/generic/simple-card.c | 2 +-
[...]
sound/soc/mxs/mxs-sgtl5000.c | 2 +- 16 files changed, 28 insertions(+), 28 deletions(-)
You split out a few drivers as separate patches but not these
ones -
what's special about these ones?
u > If it's preferred, I could send them all one file at a time, or when
the
maintainers are very similar just send one patch to all the maintainers.
Whatever works. There's no single style appropriate for the entire kernel.
Actually, I was wondering for this kind of patch specifically.
thanks, julia
On Tue, Oct 25, 2016 at 07:55:00AM +0200, Julia Lawall wrote:
On Mon, 24 Oct 2016, Mark Brown wrote:
You split out a few drivers as separate patches but not these ones - what's special about these ones?
If it's preferred, I could send them all one file at a time, or when the maintainers are very similar just send one patch to all the maintainers.
For something like this it doesn't matter so much, it was mainly just the consistency that was bothering me.
participants (3)
-
Joe Perches
-
Julia Lawall
-
Mark Brown