On Fri, Jul 15, 2011 at 11:47:41PM +0900, Mark Brown wrote:

On Fri, Jul 15, 2011 at 01:51:30PM +0100, Dimitris Papastamos wrote:

...

The WM8983 is a low power, high quality stereo CODEC designed for portable multimedia applications. Highly flexible analogue mixing functions enable new application features, combining hi-fi quality audio with voice communication.

I've applied this but there's one issue you should fix up later:

...

• /* mute all outputs and set PGAs to minimum gain */
• for (i = WM8983_LOUT1_HP_VOLUME_CTRL;

•     i <= WM8983_OUT4_MONO_MIX_CTRL; ++i)
  

• snd_soc_update_bits(codec, i, 0x40, 0x40);
  

I know you're doing this to minimise artifacts on initial bias raise but we should really be doing this without affecting the default register settings.

Well, what about using the cache_bypass option to write directly to the HW?

Thanks, Dimitris