[alsa-devel] [PATCH] ALSA: hdsp: fix memory leak
If the size of the firmware is less than expected size then we are exiting with the error code but we missed releasing the firmware.
Signed-off-by: Sudip Mukherjee sudip@vectorindia.org --- sound/pci/rme9652/hdsp.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c index 9bba275..2875b4f 100644 --- a/sound/pci/rme9652/hdsp.c +++ b/sound/pci/rme9652/hdsp.c @@ -5112,6 +5112,7 @@ static int hdsp_request_fw_loader(struct hdsp *hdsp) dev_err(hdsp->card->dev, "too short firmware size %d (expected %d)\n", (int)fw->size, HDSP_FIRMWARE_SIZE); + release_firmware(fw); return -EINVAL; }
On Fri, 11 Sep 2015 15:40:38 +0200, Sudip Mukherjee wrote:
If the size of the firmware is less than expected size then we are exiting with the error code but we missed releasing the firmware.
Signed-off-by: Sudip Mukherjee sudip@vectorindia.org
Applied, thanks.
Takashi
sound/pci/rme9652/hdsp.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c index 9bba275..2875b4f 100644 --- a/sound/pci/rme9652/hdsp.c +++ b/sound/pci/rme9652/hdsp.c @@ -5112,6 +5112,7 @@ static int hdsp_request_fw_loader(struct hdsp *hdsp) dev_err(hdsp->card->dev, "too short firmware size %d (expected %d)\n", (int)fw->size, HDSP_FIRMWARE_SIZE);
release_firmware(fw);-- 1.9.1
participants (2)
-
Sudip Mukherjee -
Takashi Iwai