[alsa-devel] Patch for au88x0 driver. Fix audacious issue and add auto reset in case of hardware ADB ctrl failure.
Hi,
does anybody still have a AU88x0 card ? I know they are quite ancient now, but if anyone could give the attached patch a try ? Would be nice. I made the patch against linux-2.6.30.4 http://micro.homelinux.net/~mjander/au88x0.diff.gz
Best Regards, Manuel
On Thursday 03 September 2009 21:10, Manuel Jander wrote:
does anybody still have a AU88x0 card ? I know they are quite ancient now, but if anyone could give the attached patch a try ? Would be nice. I made the patch against linux-2.6.30.4 http://micro.homelinux.net/~mjander/au88x0.diff.gz
Best Regards, Manuel
Well, I do have one of these in the PC to provide general-purpose sound alongside ice1712 for quality stuff, so in principle could try your patch. What is it intended to achieve? My Alsa is not very up-to-date, but that possibly won't matter anyway?
I'll try and get a chance in the next week or so if that is any help.
Alan
On 09/03/2009 10:10 PM, Manuel Jander wrote:
does anybody still have a AU88x0 card ? I know they are quite ancient now, but if anyone could give the attached patch a try ? Would be nice.
I can test an AU8820 on 2.4.37 and, if you wait >9 days, an AU8810 on a recent kernel, but what is this hunk supposed to do?:
--- linux-2.6.30.4_orig/sound/pci/au88x0/au88x0_core.c 2009-07-31 00:34:47.0000 00000 +0200 +++ linux-2.6.30.4/sound/pci/au88x0/au88x0_core.c 2009-09-02 00:13:59.4671 19172 +0200 @@ -2800,7 +2804,7 @@ { int a, this_194;
- if ((bits != 8) && (bits != 16)) + if ((bits != 8) || (bits != 16)) return -1;
switch (encod) {
Any special tests you want me to do? I don't think I have encountered a "Vortex: vortex_fifo_set*ctrl fail" message before.
Daniel
At Fri, 04 Sep 2009 11:27:51 +0200, Daniel Glöckner wrote:
On 09/03/2009 10:10 PM, Manuel Jander wrote:
does anybody still have a AU88x0 card ? I know they are quite ancient now, but if anyone could give the attached patch a try ? Would be nice.
I can test an AU8820 on 2.4.37 and, if you wait >9 days, an AU8810 on a recent kernel, but what is this hunk supposed to do?:
--- linux-2.6.30.4_orig/sound/pci/au88x0/au88x0_core.c 2009-07-31 00:34:47.0000 00000 +0200 +++ linux-2.6.30.4/sound/pci/au88x0/au88x0_core.c 2009-09-02 00:13:59.4671 19172 +0200 @@ -2800,7 +2804,7 @@ { int a, this_194;
- if ((bits != 8) && (bits != 16))
if ((bits != 8) || (bits != 16)) return -1;
switch (encod) {
This reverts the upstream fix in commit 83807400794a1d680a4fb70a610c5f486e734f45. I guess Manuel just overlooked this upstream fix.
Takashi
Hi there,
about that hunk, damn it ! I think I deleted that at least a dozen times, and it still sneaked into the final patch :( It should not be there.
Best Regards, Manuel
On Fri, Sep 4, 2009 at 11:27 AM, Daniel Glöcknerdg@emlix.com wrote:
On 09/03/2009 10:10 PM, Manuel Jander wrote:
does anybody still have a AU88x0 card ? I know they are quite ancient now, but if anyone could give the attached patch a try ? Would be nice.
I can test an AU8820 on 2.4.37 and, if you wait >9 days, an AU8810 on a recent kernel, but what is this hunk supposed to do?:
--- linux-2.6.30.4_orig/sound/pci/au88x0/au88x0_core.c 2009-07-31 00:34:47.0000 00000 +0200 +++ linux-2.6.30.4/sound/pci/au88x0/au88x0_core.c 2009-09-02 00:13:59.4671 19172 +0200 @@ -2800,7 +2804,7 @@ { int a, this_194;
- if ((bits != 8) && (bits != 16))
- if ((bits != 8) || (bits != 16))
return -1;
switch (encod) {
Any special tests you want me to do? I don't think I have encountered a "Vortex: vortex_fifo_set*ctrl fail" message before.
Daniel
-- Dipl.-Math. Daniel Glöckner, emlix GmbH, http://www.emlix.com Fon +49 551 30664-0, Fax -11, Bahnhofsallee 1b, 37081 Göttingen, Germany Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160 Geschäftsführer: Dr. Uwe Kracke, Ust-IdNr.: DE 205 198 055
emlix - your embedded linux partner
participants (4)
-
Alan Horstmann -
Daniel Glöckner -
Manuel Jander -
Takashi Iwai