[alsa-devel] [PATCH] ALSA: usb-audio: Fix memory leak in FTU quirk
M-audio FastTrack Ultra quirk doesn't release the kzalloc'ed memory. This patch adds the private_free callback to release it properly.
Cc: stable@vger.kernel.org Signed-off-by: Takashi Iwai tiwai@suse.de --- sound/usb/mixer_quirks.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c index 45203168ac6d..f6f8acf0446b 100644 --- a/sound/usb/mixer_quirks.c +++ b/sound/usb/mixer_quirks.c @@ -1021,6 +1021,7 @@ static int snd_ftu_create_effect_switch(struct usb_mixer_interface *mixer, return -ENOMEM; }
+ kctl->private_free = usb_mixer_elem_free; err = snd_ctl_add(mixer->chip->card, kctl); if (err < 0) return err;
At Tue, 11 Nov 2014 17:59:41 +0100, Takashi Iwai wrote:
M-audio FastTrack Ultra quirk doesn't release the kzalloc'ed memory. This patch adds the private_free callback to release it properly.
Cc: stable@vger.kernel.org Signed-off-by: Takashi Iwai tiwai@suse.de
Scratch this, the quirk takes private_value, not private_data. Will resubmit the correct patch.
Takashi
sound/usb/mixer_quirks.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c index 45203168ac6d..f6f8acf0446b 100644 --- a/sound/usb/mixer_quirks.c +++ b/sound/usb/mixer_quirks.c @@ -1021,6 +1021,7 @@ static int snd_ftu_create_effect_switch(struct usb_mixer_interface *mixer, return -ENOMEM; }
- kctl->private_free = usb_mixer_elem_free; err = snd_ctl_add(mixer->chip->card, kctl); if (err < 0) return err;
-- 2.1.3
participants (1)
-
Takashi Iwai