[alsa-devel] [PATCH 0/3] Add quirks for Vaio VGN
Here are some quirks for 3 Vaio VGN model reported on launchpad to need model=vaio
Pascal Terjan (3): [ALSA] Add quirk for Sony Vaio VGN-SZ650N [ALSA] Add quirk for Sony Vaio VGN-AR51M [ALSA] Add quirk for Sony Vaio VGN-FZ15G
sound/pci/hda/patch_sigmatel.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
From https://bugs.launchpad.net/ubuntu/+source/linux/+bug/195605/comments/25
Signed-off-by: Pascal Terjan pterjan@mandriva.com --- sound/pci/hda/patch_sigmatel.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index 826137e..cd91d95 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -5815,6 +5815,8 @@ static unsigned int *stac9872_brd_tbl[STAC_9872_MODELS] = { static struct snd_pci_quirk stac9872_cfg_tbl[] = { SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x81e0, "Sony VAIO F/S", STAC_9872_VAIO), + SND_PCI_QUIRK(0x104d, 0x9008, + "Sony Vaio VGN-SZ650N", STAC_9872_VAIO), {} /* terminator */ };
From https://bugs.launchpad.net/ubuntu/+source/linux/+bug/195605/comments/35
Signed-off-by: Pascal Terjan pterjan@mandriva.com --- sound/pci/hda/patch_sigmatel.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index cd91d95..9d73311 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -5817,6 +5817,8 @@ static struct snd_pci_quirk stac9872_cfg_tbl[] = { "Sony VAIO F/S", STAC_9872_VAIO), SND_PCI_QUIRK(0x104d, 0x9008, "Sony Vaio VGN-SZ650N", STAC_9872_VAIO), + SND_PCI_QUIRK(0x104d, 0x9016, + "Sony Vaio VGN-AR51M", STAC_9872_VAIO), {} /* terminator */ };
From https://bugs.launchpad.net/ubuntu/+source/linux/+bug/195605/comments/36
Signed-off-by: Pascal Terjan pterjan@mandriva.com --- sound/pci/hda/patch_sigmatel.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index 9d73311..c4310ee 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -5815,6 +5815,8 @@ static unsigned int *stac9872_brd_tbl[STAC_9872_MODELS] = { static struct snd_pci_quirk stac9872_cfg_tbl[] = { SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x81e0, "Sony VAIO F/S", STAC_9872_VAIO), + SND_PCI_QUIRK(0x104d, 0x9005, + "Sony Vaio VGN-FZ15G", STAC_9872_VAIO), SND_PCI_QUIRK(0x104d, 0x9008, "Sony Vaio VGN-SZ650N", STAC_9872_VAIO), SND_PCI_QUIRK(0x104d, 0x9016,
At Mon, 28 Sep 2009 11:43:11 +0200, Pascal Terjan wrote:
From https://bugs.launchpad.net/ubuntu/+source/linux/+bug/195605/comments/25
Signed-off-by: Pascal Terjan pterjan@mandriva.com
Thanks for the patch. I think we can merge all three using SND_PCI_QUIRK_MASK(), e.g. SND_PCI_QUIRK_MASK(0x104d, 0xff00, 0x9000, "Sony VAIO", STAC_9872_VAIO)
Or, a bit safer like SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x9000, "Sony VAIO", STAC_9872_VAIO) SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x9010, "Sony VAIO", STAC_9872_VAIO)
Could you check whether it's OK?
Also, please make sure that this change is really needed for the latest alsa-driver. The recent version probes the BIOS setup, and it should work as is unless BIOS is broken. The quirk entries like the above override the BIOS setup, thus should be used only when really needed.
thanks,
Takashi
sound/pci/hda/patch_sigmatel.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index 826137e..cd91d95 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -5815,6 +5815,8 @@ static unsigned int *stac9872_brd_tbl[STAC_9872_MODELS] = { static struct snd_pci_quirk stac9872_cfg_tbl[] = { SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x81e0, "Sony VAIO F/S", STAC_9872_VAIO),
- SND_PCI_QUIRK(0x104d, 0x9008,
"Sony Vaio VGN-SZ650N", STAC_9872_VAIO),};
-- 1.6.4.2
Le lundi 28 septembre 2009 à 11:50 +0200, Takashi Iwai a écrit :
At Mon, 28 Sep 2009 11:43:11 +0200, Pascal Terjan wrote:
From https://bugs.launchpad.net/ubuntu/+source/linux/+bug/195605/comments/25
Signed-off-by: Pascal Terjan pterjan@mandriva.com
Thanks for the patch. I think we can merge all three using SND_PCI_QUIRK_MASK(), e.g. SND_PCI_QUIRK_MASK(0x104d, 0xff00, 0x9000, "Sony VAIO", STAC_9872_VAIO)
Or, a bit safer like SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x9000, "Sony VAIO", STAC_9872_VAIO) SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x9010, "Sony VAIO", STAC_9872_VAIO)
Could you check whether it's OK?
I think so, but I can't be sure of how Sony distributed the ids
SZ61 was reported to need model=vaio to have headphones working but I could not find the ids anyway
Some commenter also reported FZ11S needed model=vaio without giving any info and without id
Given that other model seem to need it too I think that the mask would make sense
Also, please make sure that this change is really needed for the latest alsa-driver. The recent version probes the BIOS setup, and it should work as is unless BIOS is broken. The quirk entries like the above override the BIOS setup, thus should be used only when really needed.
Unfortunately we only have this for a paying customer using 2.6.29 on stable version, and who is happy with adding model=vaio. I found that other had reported on launchpad, but I don't have the hardware myself to test with kernel after July commits
At Mon, 28 Sep 2009 12:03:45 +0200, Pascal Terjan wrote:
Le lundi 28 septembre 2009 à 11:50 +0200, Takashi Iwai a écrit :
At Mon, 28 Sep 2009 11:43:11 +0200, Pascal Terjan wrote:
From https://bugs.launchpad.net/ubuntu/+source/linux/+bug/195605/comments/25
Signed-off-by: Pascal Terjan pterjan@mandriva.com
Thanks for the patch. I think we can merge all three using SND_PCI_QUIRK_MASK(), e.g. SND_PCI_QUIRK_MASK(0x104d, 0xff00, 0x9000, "Sony VAIO", STAC_9872_VAIO)
Or, a bit safer like SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x9000, "Sony VAIO", STAC_9872_VAIO) SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x9010, "Sony VAIO", STAC_9872_VAIO)
Could you check whether it's OK?
I think so, but I can't be sure of how Sony distributed the ids
SZ61 was reported to need model=vaio to have headphones working but I could not find the ids anyway
Some commenter also reported FZ11S needed model=vaio without giving any info and without id
Given that other model seem to need it too I think that the mask would make sense
Yep.
Also, please make sure that this change is really needed for the latest alsa-driver. The recent version probes the BIOS setup, and it should work as is unless BIOS is broken. The quirk entries like the above override the BIOS setup, thus should be used only when really needed.
Unfortunately we only have this for a paying customer using 2.6.29 on stable version, and who is happy with adding model=vaio. I found that other had reported on launchpad, but I don't have the hardware myself to test with kernel after July commits
Is the sound driver also based on 2.6.29 kernel, or built externally from the later version of alsa-driver? The HD-audio driver on 2.6.29 requires model=vaio explicitly while the later version of alsa-driver should work without model option as long as BIOS is correct.
So, I'm a bit worried about adding the quirks blindly.
Takashi
Le lundi 28 septembre 2009 à 12:20 +0200, Takashi Iwai a écrit :
At Mon, 28 Sep 2009 12:03:45 +0200, Pascal Terjan wrote:
Le lundi 28 septembre 2009 à 11:50 +0200, Takashi Iwai a écrit :
At Mon, 28 Sep 2009 11:43:11 +0200, Pascal Terjan wrote:
From https://bugs.launchpad.net/ubuntu/+source/linux/+bug/195605/comments/25
Signed-off-by: Pascal Terjan pterjan@mandriva.com
Thanks for the patch. I think we can merge all three using SND_PCI_QUIRK_MASK(), e.g. SND_PCI_QUIRK_MASK(0x104d, 0xff00, 0x9000, "Sony VAIO", STAC_9872_VAIO)
Or, a bit safer like SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x9000, "Sony VAIO", STAC_9872_VAIO) SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x9010, "Sony VAIO", STAC_9872_VAIO)
Could you check whether it's OK?
I think so, but I can't be sure of how Sony distributed the ids
SZ61 was reported to need model=vaio to have headphones working but I could not find the ids anyway
Some commenter also reported FZ11S needed model=vaio without giving any info and without id
Given that other model seem to need it too I think that the mask would make sense
Yep.
Also, please make sure that this change is really needed for the latest alsa-driver. The recent version probes the BIOS setup, and it should work as is unless BIOS is broken. The quirk entries like the above override the BIOS setup, thus should be used only when really needed.
Unfortunately we only have this for a paying customer using 2.6.29 on stable version, and who is happy with adding model=vaio. I found that other had reported on launchpad, but I don't have the hardware myself to test with kernel after July commits
Is the sound driver also based on 2.6.29 kernel, or built externally from the later version of alsa-driver? The HD-audio driver on 2.6.29 requires model=vaio explicitly while the later version of alsa-driver should work without model option as long as BIOS is correct.
They are using 2.6.29 audio
So, I'm a bit worried about adding the quirks blindly.
Yes better to not add them then, hopefuly they will work
participants (2)
-
Pascal Terjan -
Takashi Iwai